Get rid of StampUnbounded base class. It makes code more comples, instead of making it more simple

nataraj-hates-MS-for-stealing-github · nataraj-hates-MS-for-stealing-github · commit e167e6d3998c · 2023-01-19T14:10:06.000+03:00
diff --git a/blobstamper/stamp.h b/blobstamper/stamp.h
@@ -107,13 +107,4 @@ StampBaseV<T>::ExtractBin(Blob &blob)
   return v;
 }
 
-class StampUnbounded : public virtual StampBase
-{
-  protected:
-     int  min_size;
-  public:
-    virtual int  minSize() override {return min_size;}
-    virtual int  maxSize() override {return -1;}
-};
-
 #endif  /* STAMP_H */
diff --git a/t/test-chars-stamps.h b/t/test-chars-stamps.h
@@ -74,7 +74,8 @@ StampSeveralChars::ExtractStr(Blob &blob)
     return res;
 }
 
-class StampTwoCharsList: public StampUnbounded, public StampBaseStr
+/*****************************************************************************/
+class StampTwoCharsList: public StampBaseStr
 {
   protected:
     StampTwoChars el_stamp;
@@ -84,6 +85,7 @@ class StampTwoCharsList: public StampUnbounded, public StampBaseStr
     StampTwoCharsList(): el_stamp {}, galley {el_stamp} {};
 
     virtual int minSize() override {return el_stamp.minSize();};
+    virtual int maxSize() override {return -1;};
 };
 
 std::string

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,8 @@ StampSeveralChars::ExtractStr(Blob &blob)`
`74`	`74`	`return res;`
`75`	`75`	`}`
`76`	`76`
`77`		`-class StampTwoCharsList: public StampUnbounded, public StampBaseStr`
	`77`	`+/*****************************************************************************/`
	`78`	`+class StampTwoCharsList: public StampBaseStr`
`78`	`79`	`{`
`79`	`80`	`protected:`
`80`	`81`	`StampTwoChars el_stamp;`
`@@ -84,6 +85,7 @@ class StampTwoCharsList: public StampUnbounded, public StampBaseStr`
`84`	`85`	`StampTwoCharsList(): el_stamp {}, galley {el_stamp} {};`
`85`	`86`
`86`	`87`	`virtual int minSize() override {return el_stamp.minSize();};`
	`88`	`+ virtual int maxSize() override {return -1;};`
`87`	`89`	`};`
`88`	`90`
`89`	`91`	`std::string`