Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MarinaPolyakova
Copy link
Contributor

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add -Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.

vops_fdw.c: In function ‘foreign_grouping_ok’:
vops_fdw.c:1218:53: warning: declaration of ‘expr’ shadows a previous local [-Wshadow=compatible-local]
 1218 |                                         Expr       *expr = (Expr *) lfirst(l);
      |                                                     ^~~~
vops_fdw.c:1161:29: note: shadowed declaration is here
 1161 |                 Expr       *expr = (Expr *) lfirst(lc);
      |                             ^~~~
vops_fdw.c:1243:29: warning: declaration of ‘lc’ shadows a previous local [-Wshadow=compatible-local]
 1243 |                 ListCell   *lc;
      |                             ^~
vops_fdw.c:1118:21: note: shadowed declaration is here
 1118 |         ListCell   *lc;
      |                     ^~
vops_fdw.c:1262:29: warning: declaration of ‘lc’ shadows a previous local [-Wshadow=compatible-local]
 1262 |                 ListCell   *lc;
      |                             ^~
vops_fdw.c:1118:21: note: shadowed declaration is here
 1118 |         ListCell   *lc;
      |                     ^~
vops_fdw.c:1263:29: warning: declaration of ‘aggvars’ shadows a previous local [-Wshadow=compatible-local]
 1263 |                 List       *aggvars = pull_var_clause((Node *) fpinfo->local_conds,
      |                             ^~~~~~~
vops_fdw.c:1117:21: note: shadowed declaration is here
 1117 |         List       *aggvars;
      |                     ^~~~~~~
vops.c: In function ‘vops_import’:
vops.c:2973:49: warning: declaration of ‘dst’ shadows a previous local [-Wshadow=compatible-local]
 2973 |                                           char* dst = (char*)(tile + 1);
      |                                                 ^~~
vops.c:2828:31: note: shadowed declaration is here
 2828 |                         char* dst;
      |                               ^~~

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add
-Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.
@kovdb75
Copy link
Contributor

kovdb75 commented Nov 23, 2022

I think this commit is fine.

@kovdb75 kovdb75 merged commit 2261734 into master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants