fix: locals in inherited layout #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrum
requested changes
Dec 6, 2021
src/index.js
Outdated
| options.expressions.locals = merge(options.expressions.locals, locals); | ||
| options.plugins.push(expressions(options.expressions)); | ||
|
|
||
| var options_expressions = merge(options.expressions, {locals}); |
Member
There was a problem hiding this comment.
- Not very clear about the purpose of just such a merger?
This will cost more than the current merger - var ?
Contributor
Author
There was a problem hiding this comment.
the merge is really suboptimal, and after testing it was proven unecessary. the new variable is not needed.
src/index.js
Outdated
| options.plugins.push(expressions(options.expressions)); | ||
|
|
||
| var options_expressions = merge(options.expressions, {locals}); | ||
| var plugins = [...options.plugins, expressions(options_expressions)]; |
Contributor
Author
There was a problem hiding this comment.
😊 sorry, I've no experience in JS, I've educaded myself a little more on scoping. fixed.
Scrum
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this fixes the use case described in #44
I appreciate your feedback in this regard!