fix: copy options.expressions into new object to not pollute locals #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin merges the locals from
options.expressions.localsand thelocalsattribute into theoptions.expressions.localsproperty. Arrays in thelocalsattribute will be copied intooptions.expressions.localsand when the plugin is called again they will be merged again, doubling all array entries every time the plugin is called.posthtml-extend/src/index.js
Lines 53 to 54 in ccf454a
I fixed that by copying the
options.expressionsobject into a new object.I added a test which checks if
options.expressions.localsstays the same after rendering with the plugin. Run the GitHub Action for the commit test: add test for options.expressions.locals pollution to see the failing test. Run Actions for latest commit for succeeding tests.