Fix copying preview content and file paths over HTTP - #160
Open
dbotwinick wants to merge 1 commit into
Open
Conversation
dbotwinick
marked this pull request as ready for review
September 13, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying preview text or an absolute explorer path fails when
navigator.clipboardis unavailable, such as on a non-local HTTP origin. Use the existing user-gesture clipboard helper for both actions, including its document-copy fallback and existing error reporting.Checked both actions in an isolated browser with
navigator.clipboardunavailable; both completed successfully. Existing clipboard helper regressions are included in the full suite.Validation: formatting, lint, type checks, production build/asset budgets, and the full Bun suite (1509 passed, one live-SSH test skipped). Browser regressions ran in isolated Chromium via a Playwright launcher. The existing process-stop test exceeds the default 5-second timeout on this host; the full suite passes with
bun test --timeout 15000.