This repository was archived by the owner on Apr 11, 2024. It is now read-only.
chore: Explain incompatibility with autoupdate#39
Closed
antonagestam wants to merge 1 commit intopre-commit:mainfrom
Closed
chore: Explain incompatibility with autoupdate#39antonagestam wants to merge 1 commit intopre-commit:mainfrom
antonagestam wants to merge 1 commit intopre-commit:mainfrom
Conversation
antonagestam
commented
Mar 25, 2023
Comment on lines
+47
to
+48
| Because pre-commit cannot make difference between alpha- and other | ||
| pre-releases, this hook is not compatible with `pre-commit autoupdate`, nor can |
Author
There was a problem hiding this comment.
Please let me know if is not correctly understood, or can be clarified.
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
May 19, 2023
v3.0.0-alpha* behaves differently than v2.8.8. Since we use v2.8.8 in package.json (via `npm run prettier` / `npm run format`), we should be consistent in pre-commit, otherwise formatting behaviors may differ. The `additional_dependencies` workaround comes from https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344 and it is needed because of https://github.com/pre-commit/mirrors-prettier/issues/29. An upstream bug is available at pre-commit/mirrors-prettier#39
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
May 19, 2023
v3.0.0-alpha* behaves differently than v2.8.8. Since we use v2.8.8 in package.json (via `npm run prettier` / `npm run format`), we should be consistent in pre-commit, otherwise formatting behaviors may differ. The `additional_dependencies` workaround comes from https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344 and it is needed because of https://github.com/pre-commit/mirrors-prettier/issues/29. An upstream bug is available at pre-commit/mirrors-prettier#39
thiagowfx
pushed a commit
to GoogleChromeLabs/chromium-bidi
that referenced
this pull request
May 19, 2023
v3.0.0-alpha* behaves differently than v2.8.8. Since we use v2.8.8 in package.json (via `npm run prettier` / `npm run format`), we should be consistent in pre-commit, otherwise formatting behaviors may differ. The `additional_dependencies` workaround comes from https://github.com/pre-commit/mirrors-prettier/issues/29#issuecomment-1332667344 and it is needed because of https://github.com/pre-commit/mirrors-prettier/issues/29. An upstream bug is available at pre-commit/mirrors-prettier#39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.