-
-
Notifications
You must be signed in to change notification settings - Fork 909
More robust R hooks for Windows #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust R hooks for Windows #2885
Conversation
|
uff, some windows file issues. Here is what' ChatGPT says FWIW:
DetailsThe error code `3221225477` corresponds to the hexadecimal value `0xC0000005`, which is a common Windows error code known as the "Access Violation" or "Segmentation Fault" error. It indicates that your program attempted to access memory that it does not have permission to access.There can be various reasons why you might encounter this error when writing to a temporary file in Python on Windows. Here are a few possible causes and solutions:
If none of these solutions resolve the issue, please provide more details about your code and the specific steps you are taking that lead to the error. Additionally, if there are any relevant error messages or stack traces accompanying the error code, including those would be helpful in further diagnosing the problem. Help anyone? I am lost. |
…o tempfile instead of execute R code inline
|
it looks like R is segfaulting on windows -- no idea why -- there's no useful output to debug it. I think it might work better with a TemporaryDirectory so there aren't two things holding file handles? going to try that |
4b4e02e to
cd09c35
Compare
asottile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Perfect thank you. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | dev-dependencies | patch | `3.3.1` -> `3.3.2` | --- ### Release Notes <details> <summary>pre-commit/pre-commit</summary> ### [`v3.3.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#​332---2023-05-17) [Compare Source](pre-commit/pre-commit@v3.3.1...v3.3.2) \================== ##### Fixes - Work around `r` on windows sometimes double-un-quoting arguments. - [#​2885](pre-commit/pre-commit#2885) PR by [@​lorenzwalthert](https://github.com/lorenzwalthert). - [#​2870](pre-commit/pre-commit#2870) issue by [@​lorenzwalthert](https://github.com/lorenzwalthert). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNjEuMCJ9--> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: JayPiKay <[email protected]> Reviewed-on: https://git.goatpr0n.de/public/doxy/pulls/11 Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>

Closes #2870. I also fixed a dedention issue in
_inline_r_setupbecause ifcodehas a different indention than the string we define there. R is indention insensitive but still good to have correct indention.