Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure state updates work in signals #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
+47 −7
Merged

Ensure state updates work in signals #4560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions hooks/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export function useReducer(reducer, initialState, init) {
// We check whether we have components with a nextValue set that
// have values that aren't equal to one another this pushes
// us to update further down the tree
let shouldUpdate = false;
let shouldUpdate = hookState._component.props !== p;
stateHooks.forEach(hookItem => {
if (hookItem._nextValue) {
const currentValue = hookItem._value[0];
Expand All @@ -259,11 +259,9 @@ export function useReducer(reducer, initialState, init) {
}
});

return shouldUpdate || hookState._component.props !== p
? prevScu
? prevScu.call(this, p, s, c)
: true
: false;
return prevScu
? prevScu.call(this, p, s, c) || shouldUpdate
: shouldUpdate;
}

currentComponent.shouldComponentUpdate = updateHookState;
Expand Down
44 changes: 43 additions & 1 deletion hooks/test/browser/useState.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { setupRerender, act } from 'preact/test-utils';
import { createElement, render, createContext } from 'preact';
import { createElement, render, createContext, Component } from 'preact';
import { useState, useContext, useEffect } from 'preact/hooks';
import { setupScratch, teardown } from '../../../test/_util/helpers';

Expand Down Expand Up @@ -371,4 +371,46 @@ describe('useState', () => {
rerender();
expect(scratch.innerHTML).to.equal('<p>hello world!!!</p>');
});

describe('Global sCU', () => {
let prevScu;
before(() => {
prevScu = Component.prototype.shouldComponentUpdate;
Component.prototype.shouldComponentUpdate = () => {
return true;
};
});

after(() => {
Component.prototype.shouldComponentUpdate = prevScu;
});

it('correctly updates with multiple state updates', () => {
let simulateClick;

let renders = 0;
function TestWidget() {
renders++;
const [saved, setSaved] = useState(false);

simulateClick = () => {
setSaved(true);
setSaved(false);
};

return <div>{saved ? 'Saved!' : 'Unsaved!'}</div>;
}

render(<TestWidget />, scratch);
expect(scratch.innerHTML).to.equal('<div>Unsaved!</div>');
expect(renders).to.equal(1);

act(() => {
simulateClick();
});

expect(scratch.innerHTML).to.equal('<div>Unsaved!</div>');
expect(renders).to.equal(2);
});
});
});