Add hasScuFromHooks to mangle #4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hammering on a good way to allow for us to check the version of Preact in signals, however there hasn't really been a good one. I've come to terms with just checking whether we have
_scuFromHooksso we can ship preactjs/signals#630.The main reason why checking this is enough is that 10.12 - 10.24 would not benefit from sCU in signals being wiser either way. This because we weren't calling it either way, that got fixed in 10.25.0 by #4560.
This PR will allow us to check
this.__fand when it's present in the sCU we know that we are dealing with a state settled update so we can avoid use the check introduced in preactjs/signals#630 and when we don't have this we'll leverage the old code path.