fix(types) preact/compat missing React.Key #4864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
approved these changes
Jul 30, 2025
f2d9c6e to
0b10364
Compare
|
That was far less painful. Thx for the help! |
rschristian
reviewed
Jul 30, 2025
compat/src/index.d.ts
Outdated
| export import ReactElement = preact.VNode; | ||
| export import Consumer = preact.Consumer; | ||
| export import ErrorInfo = preact.ErrorInfo; | ||
| export import FC = preact1.FunctionComponent; |
There was a problem hiding this comment.
Glad to hear it, but I think something went a bit wrong in the merge.
There was a problem hiding this comment.
oops, sorry about that x.x
0b10364 to
98c62d1
Compare
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
thanks for being patient, I dont really use git much outside the basic operations x.x |
|
Not a problem! Git's a weird monster and I too don't venture far from the handful of commands I know, I think that's the case for most people. Thanks again! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preact/compat is missing the React.Key export