[945] Update boolean attributes to be empty value for consistency#983
[945] Update boolean attributes to be empty value for consistency#983timurista wants to merge 7 commits into
Conversation
developit
left a comment
There was a problem hiding this comment.
Nice! Need to figure out if there's a way to compress this :)
|
@developit did you want me to still merge this? Which part still needs to be compressed? Are we talking the elseif statement or something else? |
|
Not sure yet - let's leave it open for a bit, we won't be cutting a release until next week. |
|
sure, np 👍 sounds good to me |
…thout explicitly assinging value
…of tag is considered true
63ea8a2 to
a16e084
Compare
|
@developit any news on the perf-review? |
|
I'm concerned that this may cause issues with some DOM Boolean Attributes, but haven't been able to determine if that's likely or not. |
|
@developit you want me to close this then? |
|
no - I want to write some tests around it and was hoping to have time to research the effects. I actually think we should merge this, I just need to be sure of the implications. |
|
@developit this is very out of date, you want me to close it? |
Change boolean attributes to have empty value
In response to #945
I added an explicit check in case the value === "true" which simply sets attribute to "" which is inline with web standard in moz docs: https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute
I also updated the test to make sure it renders empt value instead of ="true"