-
-
Notifications
You must be signed in to change notification settings - Fork 993
Add support for UNLINK #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a2f653
to
0e7fa55
Compare
0e7fa55
to
a56ab84
Compare
@nicolas-grekas thank you for the patch, but just to make it clear it targets the |
I'd be happy to target a lower branch. It should be 1.2 then, isn't it (unless you'd consider this as a bugfix?) |
Actually I missed the line in symfony/symfony#37993 with the check
To be honest I would have liked to avoid introducing a v1.2 and stick with patch releases for v1.1, but aside from @predis/team what should we do, branch off a new v1.2 branch and leave v1.1 as is or just stick with v1.1? |
I guess v1.1patch releases makes sense. |
I don't consider this a bug fix, so I'm not sure I think it should go into v1.1. A v1.2 would make more sense to me. |
Fine to me for 1.2 of course. How can I help make this happen? |
Feel free to re-submit to the |
From https://redis.io/commands/unlink
Found missing while working on symfony/symfony#37993