Todo highlighting in html comments#642
Draft
lggruspe wants to merge 4 commits intopreservim:masterfrom
Draft
Conversation
alerque
previously approved these changes
Sep 20, 2023
alerque
requested changes
Sep 20, 2023
Member
alerque
left a comment
There was a problem hiding this comment.
Tests not passing, I'm guessing the behavior is correct just the expectations are incorrect.
Contributor
Author
|
I made the tests pass, but there are still some issues with this PR. Currently, it can't detect TODO comments without a preceding space. For example, <!--TODO this doesn't get highlighted -->
<!-- TODO but this one does --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369
Highlights TODO, FIXME, XXX and TBD inside html comments.