-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add release notes for 0.260 #16619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 0.260 #16619
Conversation
* Add session property ``query_max_revocable_memory_per_node`` to override existing configuration property ``experimental.max-revocable-memory-per-node``. | ||
* Add support for Prometheus connector plugin. | ||
* Introduce a new config ``optimizer.aggregation-if-to-filter-rewrite-enabled`` and its corresponding session property ``aggregation_if_to_filter_rewrite_enabled`` to enable or disable an optimizer rule to improve the query performance of ``IF`` expressions inside aggregation functions. | ||
* When spill is enabled, enable join spilling by default. This can be disabled by setting the configuration property ``experimental.join-spill-enabled`` or session property ``join_spill_enabled`` to ``false``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about changing this to -
Enable join spilling by default when spill is enabled. This can be disabled by setting the configuration property experimental.join-spill-enabled
or session property join_spill_enabled
to false
.
4458ef5
to
f556993
Compare
* Add configuration property ``experimental.window-spill-enabled`` to control window spills explicitly. This can be overridden by ``window_spill_enabled`` session property. | ||
* Add configuration property `fragment-result-cache.max-single-pages-size` to control the max fragement cache file size. | ||
* Add session property ``query_max_revocable_memory_per_node`` to override existing configuration property ``experimental.max-revocable-memory-per-node``. | ||
* Add support for Prometheus connector plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to go into the Connectors section.
see https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#order-of-sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adding a new connector and not a change in the connector. I am not sure where it needs to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make a new section Prometheus Connector Changes
add to that -
* Added Prometheus Connector. See :doc:`connector/prometheus`
_______________ | ||
* Fix a bug in sql functions that would cause compiler error when session property ``inline_sql_function`` is set to ``false`` and sql function references input in lambda expression. | ||
* Fix multithread writing for fragment result cache. | ||
* Add UUID type and operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ``UUID`` type and operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ``UUID`` type. See :doc:`types`
The fact that we added operators like LIKE
, CAST
is not that important (rather expected I'd guess) - so we can skip those.
* Add configuration property ``experimental.aggregation-spill-enabled`` to control aggregate spills explicitly. This can be overridden by ``aggregation_spill_enabled`` session property. | ||
* Add configuration property ``experimental.order-by-spill-enabled`` to control order by spills explicitly. This can be overridden by ``order_by_spill_enabled`` session property. | ||
* Add configuration property ``experimental.window-spill-enabled`` to control window spills explicitly. This can be overridden by ``window_spill_enabled`` session property. | ||
* Add configuration property `fragment-result-cache.max-single-pages-size` to control the max fragement cache file size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double quotes for the property.
|
||
Hive Changes | ||
____________ | ||
* Allow multiple or missing Hive bucket files. This can be configured by using configuration property ``hive.create-empty-bucket-files``. Updated bucket file names to use Hive naming convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we reword this to make it more clear.
trinodb/trino#776 (comment) this reads so much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! I will just copy them
**Highlights** | ||
============== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remove this if there are no highlights
|
||
General Changes | ||
_______________ | ||
* Fix a bug in sql functions that would cause compiler error when session property ``inline_sql_function`` is set to ``false`` and sql function references input in lambda expression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sql
-> SQL
General Changes | ||
_______________ | ||
* Fix a bug in sql functions that would cause compiler error when session property ``inline_sql_function`` is set to ``false`` and sql function references input in lambda expression. | ||
* Fix multithread writing for fragment result cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too low level. We should write it in a way such that it is clear what is the end impact. Did this lead to a query failure ? Did this lead to a performance regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shixuan-fan Can you provide more details here since you reviewed this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: Fix a bug in fragment result cache that might cause query failure
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix a bug in fragment result cache that caused query failures
_______________ | ||
* Fix a bug in sql functions that would cause compiler error when session property ``inline_sql_function`` is set to ``false`` and sql function references input in lambda expression. | ||
* Fix multithread writing for fragment result cache. | ||
* Add UUID type and operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ``UUID`` type. See :doc:`types`
The fact that we added operators like LIKE
, CAST
is not that important (rather expected I'd guess) - so we can skip those.
* Add configuration property ``experimental.window-spill-enabled`` to control window spills explicitly. This can be overridden by ``window_spill_enabled`` session property. | ||
* Add configuration property `fragment-result-cache.max-single-pages-size` to control the max fragement cache file size. | ||
* Add session property ``query_max_revocable_memory_per_node`` to override existing configuration property ``experimental.max-revocable-memory-per-node``. | ||
* Add support for Prometheus connector plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make a new section Prometheus Connector Changes
add to that -
* Added Prometheus Connector. See :doc:`connector/prometheus`
* Add configuration property ``experimental.aggregation-spill-enabled`` to control aggregate spills explicitly. This can be overridden by ``aggregation_spill_enabled`` session property. | ||
* Add configuration property ``experimental.order-by-spill-enabled`` to control order by spills explicitly. This can be overridden by ``order_by_spill_enabled`` session property. | ||
* Add configuration property ``experimental.window-spill-enabled`` to control window spills explicitly. This can be overridden by ``window_spill_enabled`` session property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at how to phrase the line when we have both configuration and session property - https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#phrasing
* Add configuration property `fragment-result-cache.max-single-pages-size` to control the max fragement cache file size. | ||
* Add session property ``query_max_revocable_memory_per_node`` to override existing configuration property ``experimental.max-revocable-memory-per-node``. | ||
* Add support for Prometheus connector plugin. | ||
* Add configuration property ``optimizer.aggregation-if-to-filter-rewrite-enabled`` and its corresponding session property ``aggregation_if_to_filter_rewrite_enabled`` to enable or disable an optimizer rule to improve the query performance of ``IF`` expressions inside aggregation functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to toggle the optimization which improves performance of ``IF`` expressions inside aggregation functions
* Add configuration property ``optimizer.aggregation-if-to-filter-rewrite-enabled`` and its corresponding session property ``aggregation_if_to_filter_rewrite_enabled`` to enable or disable an optimizer rule to improve the query performance of ``IF`` expressions inside aggregation functions. | ||
* Enable join spilling by default when spill is enabled. This can be disabled by setting the configuration property ``experimental.join-spill-enabled`` or session property ``join_spill_enabled`` to ``false``. | ||
|
||
Hive Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hive Connector Changes
____________ | ||
* Allow multiple or missing Hive bucket files. This can be configured by using configuration property ``hive.create-empty-bucket-files``. Updated bucket file names to use Hive naming convention. | ||
|
||
Iceberg Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iceberg Connector Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was just talking to @ajaygeorge about adding connector in the names. Good that you called it out.
f556993
to
d317cd2
Compare
* Add configuration property ``experimental.window-spill-enabled`` and session property ``window_spill_enabled`` to control window spills explicitly. | ||
* Add configuration property ``fragment-result-cache.max-single-pages-size`` to control the max fragement cache file size. | ||
* Add session property ``query_max_revocable_memory_per_node`` to override existing configuration property ``experimental.max-revocable-memory-per-node``. | ||
* Add configuration property ``optimizer.aggregation-if-to-filter-rewrite-enabled`` and session property ``aggregation_if_to_filter_rewrite_enabled`` to toggle an optimizer rule which improves the query performance of ``IF`` expressions inside aggregation functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improves the performance of
instead of query performance
|
||
Hive Connector Changes | ||
______________________ | ||
* Use Hive naming convention for bucket file names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unclear to me. Is there some documentation from Hive or something that can make this clear?
Hive Connector Changes | ||
______________________ | ||
* Use Hive naming convention for bucket file names. | ||
* Allow disabling the creation of files for empty buckets when writing data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support to create files for empty buckets when writing data
d317cd2
to
ac60281
Compare
Missing Release Notes
Bin Fan
vaishnavibatni
Extracted Release Notes
hive.create-empty-bucket-files
. Changes are also made to use Hive naming convention for bucket file names when computing bucket file name.optimizer.aggregation-if-to-filter-rewrite-enabled
and its corresponding session propertyaggregation_if_to_filter_rewrite_enabled
to enable or disable an optimizer rule to improve the query performance ofIF
expressions inside aggregation functions.fragment-result-cache.max-single-pages-size
to control the max fragement cache file size.experimental.join-spill-enabled
or session propertyjoin_spill_enabled
tofalse
.query_max_revocable_memory_per_node
to override existing configuration propertyexperimental.max-revocable-memory-per-node
.inline_sql_function
is set tofalse
.experimental.aggregation-spill-enabled
to control aggregate spills explicitly. This can be overridden byaggregation_spill_enabled
session property.experimental.window-spill-enabled
to control window spills explicitly. This can be overridden bywindow_spill_enabled
session property.experimental.order-by-spill-enabled
to control order by spills explicitly. This can be overridden byorder_by_spill_enabled
session property.All Commits