[native] Dynamically Linked Library in Presto CPP #24330

soumiiow · 2025-01-07T17:10:21Z

Description

Depends on facebookincubator/velox#11439 in the Velox space
and based off of the following PR: https://github.com/facebookincubator/velox/pull/1005/files

Motivation and Context

Having these changes will enable users to register custom functions dynamically without requiring a fork of Prestissimo.

Impact

This extends Prestissimo functionality to include dynamic loading of functions, types, connectors, etc.

Test Plan

Unit tested. and Manually end to end tested the changes.

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

linux-foundation-easycla · 2025-01-07T17:10:27Z

The committers listed above are authorized under a signed CLA.

✅ login: soumiiow / name: Soumya Duriseti (526ee07)

czentgr

Please also rebase.

czentgr · 2025-02-03T19:32:42Z

presto-native-execution/presto_cpp/main/CMakeLists.txt

@@ -76,7 +76,8 @@ target_link_libraries(
  ${FOLLY_WITH_DEPENDENCIES}
  ${GLOG}
  ${GFLAGS_LIBRARIES}
-  pthread)
+  pthread
+  velox_dynamic_function_loader)


Move this before the velox_encode library.

czentgr · 2025-02-03T19:33:09Z

presto-native-execution/presto_cpp/main/CMakeLists.txt

@@ -89,6 +90,7 @@ set_property(TARGET presto_server_lib PROPERTY JOB_POOL_LINK
                                               presto_link_job_pool)

 add_executable(presto_server PrestoMain.cpp)
+target_link_options(presto_server BEFORE PUBLIC "-Wl,-export-dynamic")


Can we add a comment here why we need these flags?

czentgr · 2025-02-03T19:35:24Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+    const fs::path path(systemConfig->pluginDir());
+    PRESTO_STARTUP_LOG(INFO) << path;
+    std::error_code
+        ec; // For using the non-throwing overloads of functions below.


We don;t need this comment here and so can fix up the odd formatting.

czentgr · 2025-02-03T19:35:52Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+void PrestoServer::registerDynamicFunctions() {
+  auto systemConfig = SystemConfig::instance();
+  if (!systemConfig->pluginDir().empty()) {
+    // if it is a valid directory, traverse and call dynamic function loader


Please make sure the comments are full sentences beginning with capitalization etc.

czentgr · 2025-02-03T19:37:42Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+        auto dirEntryPath = dirEntry.path();
+        if (!fs::is_directory(dirEntry, ec) &&
+            extensions.find(dirEntryPath.extension()) != extensions.end()) {
+          facebook::velox::loadDynamicLibrary(dirEntryPath.c_str());


facebook is not needed here because we are already in the facebook namespace.

steveburnett

Thanks for the doc! A few minor formatting and phrasing suggestions.

presto-native-execution/presto_cpp/main/dynamic_registry/README.md

steveburnett

Thanks for the documentation! I really liked your including the setup steps on plugin.rst. Some minor suggestions for formatting and phrasing but looks good overall.

presto-native-execution/presto_cpp/main/dynamic_registry/README.md

presto-docs/src/main/sphinx/presto_cpp/plugin.rst

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

soumiiow · 2025-02-11T22:24:12Z

Thanks @steveburnett please take another look, I've made the changes. I'm not sure about the tone on the intro to UDFs i have on function_plugin.rst, would appreciate another set of eyes there.

steveburnett

Thanks for the revision! Nice work, your unordered list of UDF benefits was great and the format fixes in the README look good.

I made a couple of small suggestions about the intro to UDFs, let me know what you think.

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

steveburnett

I should have noticed this spelling nit earlier! After I found this one, I did a complete review of the doc in this PR and found no other errors so I think this is the last one.

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

soumiiow · 2025-02-24T22:34:08Z

Hey @pedroerp! I was looking through remote_function_server.json to design the config for the dylib changes to be simple to use and similar to the remote fn registrations so as to make for a seamless user experience.

I was curious as to the intended purpose of the schema object for the remote function registrations.

In prestissimo, when we use a prefix/namespace like presto.default, is the equivalent for remote function registrations that "default" would be the schema and that "presto" would be the prefix?

also, i notice that in PrestoServer.cpp, prefix is set to systemConfig->remoteFunctionServerCatalogName(). For remote functions, does this imply that the prefix name would be set for all remote fns and only the schema name would change?

PingLiuPing · 2025-02-24T22:39:19Z

presto-native-execution/presto_cpp/main/dynamic_registry/CMakeLists.txt

+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+add_subdirectory(examples)


I think there is potential issues with regard to upgrading.
You need to fix this by changing some script to trigger the building of the dynamic library when upgrading (from customer perspective). This gurrantee the ABI compatibility in case of major compiler upgrade.
Well this requires the source code should be under some specific directory of presto installation path.

Discussed offline about ABI compatibility issues and came up with documentation changes to alert the users to rebuild shared libraries upon upgrades manually.
presto-docs/src/main/sphinx/presto_cpp/plugin.rst

soumiiow · 2025-03-20T09:28:56Z

Updated the RFC with the discussions regarding adding a Json config, function validation, customizable entrypoint, and signal handling so as to not crash the worker here prestodb/rfcs#24. please take a look!

steveburnett

Thanks for the doc! This will be great to have in the doc. I have some suggestions for conciseness and readability, and a couple of questions for you to consider. Let me know what you think, please!

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

presto-native-execution/presto_cpp/main/dynamic_registry/README.md

presto-docs/src/main/sphinx/presto_cpp/plugin.rst

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

aditi-pandit

@soumiiow : Did a quick pass of your code. Its overall a good design for the first-cut implementation.

presto-native-execution/presto_cpp/main/PrestoServer.cpp

aditi-pandit · 2025-03-31T19:57:52Z

presto-native-execution/presto_cpp/main/JsonSignatureParser.h

+///      "my_function": [
+///        {
+///          "outputType": "integer",
+///         "entrypoint": "nameOfRegistryFnCall",


Fix the formating of this line.

aditi-pandit · 2025-03-31T20:05:21Z

presto-native-execution/presto_cpp/main/dynamic_registry/DynamicFunctionConfigRegisterer.h

+  int64_t compareConfigWithRegisteredFunctionSignatures(
+      facebook::velox::FunctionSignatureMap fnSignaturesBefore);
+
+  std::


Add a shorthand for
std::unordered_map<std::string, std::vectorvelox::exec::FunctionSignaturePtr> with "using" statement.

aditi-pandit · 2025-03-31T20:07:31Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+        DynamicLibraryValidator dVal(configPath, systemConfig->pluginDir());
+        auto filenameAndEntrypointMap = dVal.getEntrypointMap();
+        auto registeredFnSignaturesBefore = velox::getFunctionSignatures();
+        for (const auto& entryPointItr : filenameAndEntrypointMap) {


All this logic can be moved into the DynamicLibraryValidator class (maybe call it DynamicLibraryLoader instead).

The code here would only read the config entries for plugin.dir and dynamiclibraryvalidator and pass them to DynamicLibraryLoader.

aditi-pandit · 2025-03-31T20:09:51Z

presto-native-execution/presto_cpp/main/tests/JsonSignatureParserTest.cpp

@@ -197,5 +197,52 @@ TEST_F(JsonSignatureParserTest, multiple) {
  EXPECT_EQ(signature1->argumentTypes()[1].baseName(), "varchar");
 }

+TEST_F(JsonSignatureParserTest, dynamic) {
+  auto input = R"(


Please add a function which uses a complex type for either paramType or outputType

aditi-pandit · 2025-03-31T20:16:40Z

presto-native-execution/presto_cpp/main/tests/DynamicFunctionRegistererTest.cpp

+    }
+  })";
+
+  // Emulate user provided config file.


There is a some repetition of code between this and the test below. Can you make common functions for reuse ?

aditi-pandit · 2025-03-31T20:18:26Z

...ynamic_registry/examples/function_registerations_non_default/MyDynamicNonDefaultFunction.cpp

Is there a need to separate the directories for this file from the previous directory ?

If yes, then it might be worth trying a recursive directory scenario as well.

aditi-pandit · 2025-03-31T20:19:35Z

...esto_cpp/main/dynamic_registry/examples/function_registerations/MyDynamicVarcharFunction.cpp

Please remove the usage of "My" in the naming of these files.

steveburnett

Thanks for the updated doc! Just a couple of small nits.

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst

steveburnett

Thanks for the doc update! A couple minor formatting issues, nothing important.

presto-docs/src/main/sphinx/presto_cpp/plugin.rst

aditi-pandit

Thanks @soumiiow. Have a bunch of minor comments.

aditi-pandit · 2025-04-25T20:03:12Z

presto-native-execution/presto_cpp/main/PrestoServer.h

@@ -188,6 +188,8 @@ class PrestoServer {

  VeloxPlanValidator* getVeloxPlanValidator();

+  virtual void registerDynamicFunctions();


Virtual might not be needed here. Please can you remove it.

presto-native-execution/presto_cpp/main/PrestoServer.cpp

aditi-pandit · 2025-04-25T20:07:43Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+void PrestoServer::registerDynamicFunctions() {
+  auto systemConfig = SystemConfig::instance();
+  std::error_code ec;
+  const fs::path configPath(systemConfig->dynamicLibraryValidatorConfig());


This code should check for empty config and just log a message and return in that case.

aditi-pandit · 2025-04-25T20:08:37Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+    LOG(ERROR) << "Config file not found in path: " << configPath
+               << ". Dynamic libraries will not be loaded on this worker run.";
+    return;
+  } else {


else is not needed because of the return in the if part of the condition.

aditi-pandit · 2025-04-25T20:09:42Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+               << ". Dynamic libraries will not be loaded on this worker run.";
+    return;
+  } else {
+    if (!systemConfig->pluginDir().empty()) {


If there is a config but the pluginDir is not there, then should there be a log message for it ?

aditi-pandit · 2025-04-25T21:04:10Z

...e-execution/presto_cpp/main/dynamic_registry/examples/function_registerations/CMakeLists.txt

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+add_library(presto_function_my_dynamic SHARED DynamicFunction.cpp)


Please remove the usage of "my" in all the library names, etc in this file.

aditi-pandit · 2025-04-25T21:04:28Z

...e-execution/presto_cpp/main/dynamic_registry/examples/function_registerations/CMakeLists.txt

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+add_library(presto_function_my_dynamic SHARED DynamicFunction.cpp)


Its alright to remove the usage of the presto prefix as well.

aditi-pandit · 2025-04-25T21:08:37Z

presto-native-execution/presto_cpp/main/tests/DynamicFunctionRegistererTest.cpp

+    outputFile.close();
+  }
+
+  void emulateConfigFile(std::string_view json, std::string pathStr) {


Remove commented code.

aditi-pandit · 2025-04-25T21:08:55Z

presto-native-execution/presto_cpp/main/tests/DynamicFunctionRegistererTest.cpp

+    outputFile.close();
+  }
+
+  void emulateConfigFile(std::string_view json, std::string pathStr) {


Nit rename "createConfigFile"

aditi-pandit · 2025-04-25T21:11:21Z

presto-native-execution/presto_cpp/main/tests/DynamicFunctionRegistererTest.cpp

+
+  // Check functions do not exist first.
+  auto registeredFnSignaturesBefore = velox::getFunctionSignatures();
+  EXPECT_TRUE(


Write functions for existsBefore/After or notExistsBefore/After and use them in the tests instead of doing a find and checking the returned iterator.

steveburnett

Thanks for the update! Just one nit of formatting.

presto-docs/src/main/sphinx/presto_cpp/plugin.rst

steveburnett

Hi! I think these suggestions should fix the doc.

presto-docs/src/main/sphinx/presto_cpp/plugin.rst

czentgr

Before looking too deeply into this, there are failures in the CI. Please investigate.

czentgr · 2025-05-05T19:25:36Z

presto-native-execution/presto_cpp/main/CMakeLists.txt

@@ -100,6 +105,16 @@ set_property(TARGET presto_server_lib PROPERTY JOB_POOL_LINK
                                               presto_link_job_pool)

 add_executable(presto_server PrestoMain.cpp)
+target_link_options(presto_server PRIVATE "-no-pie")


This might be a problem because there are security concerns with this. Is this because the shared library loaded is not setting PIC?

I see what you mean, looks like something to do with PIC codes...

However, when I remove this flag on my linux build and try to make, I get the below error...
/usr/bin/ld: /usr/local/lib/libthriftprotocol.a(CompactProtocol.cpp.o): relocation R_X86_64_PC32 against undefined hidden symbol _ZTCN6apache6thrift8protocol18TProtocolExceptionE0_NS0_17TLibraryExceptionE' can not be used when making a PIE object
/usr/bin/ld: final link failed: bad value`

it looks like the thrift library is being built statically and therefore setting the PIC is not happening because its a static library

czentgr · 2025-05-05T19:28:16Z

presto-native-execution/presto_cpp/main/JsonSignatureParser.cpp

@@ -70,12 +83,19 @@ JsonSignatureParser::FunctionSignatureItem parseSignature(
          std::move(paramTypeSignatures),
          std::move(constantArguments),
          /*variableArity=*/false),
-      (schema != nullptr) ? schema->asString() : ""};
+      (schema != nullptr) ? schema->asString() : "",


This looks weird because these are additional arguments to FunctionSignature so should all be aligned with the previous ones. The make format-fix didn't do anything here?

hmm i just reran make format-fix and nothing happened...
I think (schema != nullptr) ? schema->asString() : "", is an addtl argument to FunctionSignatureItem not FunctionSignature and is therefore indented at the same level as FunctionSignature

soumiiow · 2025-05-05T19:41:03Z

@czentgr I am currently expecting CI build errors due to the relevant velox PR still in review and is yet to be merged. facebookincubator/velox#12878

Other than that, I see CI errors in product-tests-specific-environment2 that are separate from this that I will look into

aditi-pandit

@soumiiow :

Have you used the functions in the examples folder anywhere ... don't think they are exercised in any test ? Are you intending that they will be used in an e2e test ?

aditi-pandit · 2025-05-05T19:11:52Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+  }
+  if (!systemConfig->pluginDir().empty()) {
+    const fs::path path(systemConfig->pluginDir());
+    PRESTO_STARTUP_LOG(INFO) << "Dynamic library loading path: " << path;


Change this log message to "Loading dynamic libraries from in "

aditi-pandit · 2025-05-05T19:13:07Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+                 << systemConfig->pluginDir() << "is invalid.";
+    }
+  } else {
+    LOG(ERROR) << "plugin.dir configuration not set up.";


Many installations like say Meta will not setup plugin.dir, so this shouldn't be an error right ?

thats a great point. @aditi-pandit is it ok to make it a LOG(INFO) statement or would it be unnecessary given that not all installations will want to set a plugin dir

aditi-pandit · 2025-05-05T19:19:17Z

presto-native-execution/presto_cpp/main/dynamic_registry/DynamicLibraryLoader.cpp

+  std::string name;
+  if (nameSpace.empty()) {
+    // auto systemConfig = SystemConfig::instance();
+    // std::string defaultPrefix = systemConfig->prestoDefaultNamespacePrefix();


Remove commented code

aditi-pandit · 2025-05-05T19:22:20Z

.../presto_cpp/main/dynamic_registry/examples/default_registrations/DynamicFunctionVeloxCon.cpp

+namespace facebook::velox::common::dynamicRegistry {
+template <typename T>
+struct DynamicFunction {
+  FOLLY_ALWAYS_INLINE bool call(int64_t& result, int64_t in) {


This is almost the same as the previous function. Is this needed ?

good point. getting rid of this

soumiiow · 2025-05-05T20:03:11Z

Have you used the functions in the examples folder anywhere ... don't think they are exercised in any test ? Are you intending that they will be used in an e2e test ?

hi @aditi-pandit yes currently they're not being used in any tests, theyll serve as examples alongside the presto docs documentation for now. the idea for the e2e tests is that yes they should be making use of examples to test for proper registration

steveburnett

LGTM! (docs)

Pull updated branch, new local doc build. Thanks!

soumiiow self-assigned this Jan 7, 2025

soumiiow force-pushed the dylib_new branch from 58ce37c to aedfb72 Compare January 7, 2025 17:16

soumiiow marked this pull request as ready for review January 7, 2025 18:04

soumiiow requested a review from a team as a code owner January 7, 2025 18:04

tdcmeehan self-assigned this Jan 8, 2025

soumiiow mentioned this pull request Jan 14, 2025

presto requires namespaces when using function registration #24363

Open

tdcmeehan added the from:IBM PR from IBM label Jan 30, 2025

prestodb-ci requested review from a team, pdabre12 and psnv03 and removed request for a team January 30, 2025 18:47

czentgr reviewed Feb 3, 2025

View reviewed changes

soumiiow force-pushed the dylib_new branch from aedfb72 to 9cde5a4 Compare February 3, 2025 21:23

soumiiow requested review from steveburnett and a team as code owners February 3, 2025 21:23

soumiiow requested a review from presto-oss February 3, 2025 21:23

steveburnett requested changes Feb 4, 2025

View reviewed changes

soumiiow force-pushed the dylib_new branch from 9cde5a4 to 689b24e Compare February 11, 2025 09:31

soumiiow requested a review from elharo as a code owner February 11, 2025 09:31

soumiiow requested a review from steveburnett February 11, 2025 09:33

soumiiow force-pushed the dylib_new branch from 689b24e to 6cb96e7 Compare February 11, 2025 10:00

steveburnett requested changes Feb 11, 2025

View reviewed changes

soumiiow force-pushed the dylib_new branch from 6cb96e7 to 0ab37d6 Compare February 11, 2025 22:20

steveburnett requested changes Feb 11, 2025

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst Outdated Show resolved Hide resolved

soumiiow force-pushed the dylib_new branch from 0ab37d6 to d8b7dc2 Compare February 12, 2025 18:51

soumiiow requested a review from steveburnett February 12, 2025 18:52

steveburnett requested changes Feb 12, 2025

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst Outdated Show resolved Hide resolved

soumiiow force-pushed the dylib_new branch from d8b7dc2 to 27bd55e Compare February 12, 2025 19:15

soumiiow requested a review from PingLiuPing February 19, 2025 22:19

PingLiuPing reviewed Feb 24, 2025

View reviewed changes

soumiiow force-pushed the dylib_new branch 2 times, most recently from a8d2204 to 173ecc9 Compare March 27, 2025 01:16

soumiiow requested review from steveburnett and PingLiuPing March 27, 2025 01:18

steveburnett requested changes Mar 27, 2025

View reviewed changes

aditi-pandit reviewed Mar 31, 2025

View reviewed changes

soumiiow force-pushed the dylib_new branch 2 times, most recently from 94d57ba to 9ef0b63 Compare April 7, 2025 22:36

soumiiow requested review from steveburnett and aditi-pandit April 8, 2025 00:07

steveburnett requested changes Apr 8, 2025

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/presto_cpp/plugin/function_plugin.rst Outdated Show resolved Hide resolved

soumiiow force-pushed the dylib_new branch from 9ef0b63 to 9174c63 Compare April 21, 2025 19:04

soumiiow requested a review from steveburnett April 21, 2025 19:05

steveburnett requested changes Apr 21, 2025

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/plugin.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/presto_cpp/plugin.rst Outdated Show resolved Hide resolved

aditi-pandit reviewed Apr 25, 2025

View reviewed changes

steveburnett requested changes Apr 28, 2025

View reviewed changes

presto-docs/src/main/sphinx/presto_cpp/plugin.rst Outdated Show resolved Hide resolved

soumiiow force-pushed the dylib_new branch 2 times, most recently from d9ea7d6 to 55d1941 Compare April 29, 2025 16:43

steveburnett requested changes Apr 29, 2025

View reviewed changes

czentgr reviewed May 5, 2025

View reviewed changes

aditi-pandit reviewed May 5, 2025

View reviewed changes

addressed comments on new changes with config based validation + tests

526ee07

soumiiow force-pushed the dylib_new branch from 55d1941 to 526ee07 Compare May 5, 2025 20:31

steveburnett approved these changes May 5, 2025

View reviewed changes

		@@ -188,6 +188,8 @@ class PrestoServer {

		VeloxPlanValidator* getVeloxPlanValidator();

		virtual void registerDynamicFunctions();

[native] Dynamically Linked Library in Presto CPP #24330

Are you sure you want to change the base?

[native] Dynamically Linked Library in Presto CPP #24330

Conversation

soumiiow commented Jan 7, 2025

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

linux-foundation-easycla bot commented Jan 7, 2025 • edited Loading

czentgr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

soumiiow commented Feb 11, 2025

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

soumiiow commented Feb 24, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soumiiow commented Mar 20, 2025

steveburnett left a comment

Choose a reason for hiding this comment

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

czentgr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soumiiow commented May 5, 2025

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soumiiow commented May 5, 2025

steveburnett left a comment

linux-foundation-easycla bot commented Jan 7, 2025 •

edited

Loading