Jetty Upgrade (Jitpack) #24869
Draft
Jetty Upgrade (Jitpack) #24869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84e6ee8 to
2834460
Compare
6c228d9 to
122e4e2
Compare
704a168 to
163512b
Compare
This could be done in a single file, but by splitting this up it will allows contributors and maintainers to incrementally re- enable the modernizer on each module since it will cause lots of code change. It will also introduce lots of opportunities for new contributors to get involved with Presto.
- Spark requires certain versions of jersey, javax.rs.ws-api and javax.serlet-api in order to run. This change ensures that we use the correct library versions at runtime. The versions chosen correspond to those used in Spark 2.4.4 which is the spark version inside of Presto's spark-core dependency
This change expands the OVERRIDE_JDK_DIR environment configuration to the tempto runner in addition to the existing behavior for the presto coordinator and workers inside of the product tests suite. run_tempto.sh was updated to detect the overridden jdk volume when executing in order to make the tests run on a compatible JDK since product tests compiles to java 17 bytecode by default
This makes URI compliance checks in the REST catalog server more lax during tests in order to comply with the request URIs generated by the Iceberg rest catalog spec
- remove build-airlift to disable misbehaving profile from airbase - mostly renames - some exclusions for airlift deps in the original namespaces - upgrade discovery-server
163512b to
083b450
Compare
In Java 17, when URI.create is called on a a String, the string is URL encoded. This will cause encoded strings to be encoded twice if the input is already URL encoded. For example %3B will become %253B to encode the '%' character. Newer Jetty servers reject requests encoded with %25xxx as "AMBIGUOUS_PATH_PARAMETER". However, if the String is not URL encoded, it will be encoded as normal in URI.create. The ; character is actually allowed as a delimiter for path parameters. See RFC 3986 S3.3 which means that when passing it directly to URI.create, the semicolon is left in place and not encoded. This presents a problem for the function server API since we will not be able to create URIs easily that are encoded. This change updates the delimiter used to be `|` which is not in the reserved URI delimiter list.
- remove airline from classpath by excluding it from com.teradata.tpcds:tpcds - force presto-product-tests to shade airline by disabling the generation of the dependency-reduced-pom - change message() to body() in StatementClient to get correct error messages
083b450 to
924fe15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to minimum version of java 17 and pull up jetty.
This branch uses jitpack to depend on an unpublished version of airlift