Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to integer based streaming aggregation output batch session #25029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

tanjialiang
Copy link
Contributor

@tanjialiang tanjialiang commented May 1, 2025

Description

The old boolean based eager flush streaming aggregation session property only allows threshold to be 1. The new one allows a customized integer based configuration.

== NO RELEASE NOTE ==
  • Added session property native_streaming_aggregation_min_output_batch_rows
  • Remove session property native_streaming_aggregation_eager_flush

@tanjialiang tanjialiang requested review from steveburnett, elharo and a team as code owners May 1, 2025 22:53
@tanjialiang tanjialiang requested a review from ZacBlanco May 1, 2025 22:53
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label May 1, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Some rephrasing suggestions, let me know what you think.

@tanjialiang tanjialiang requested a review from steveburnett May 2, 2025 21:31
@tanjialiang
Copy link
Contributor Author

Thanks for the doc! Some rephrasing suggestions, let me know what you think.

Thanks for the suggestions. Makes sense and accepted.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good.

Thanks for the doc!

@tanjialiang tanjialiang merged commit 0e0572e into prestodb:master May 5, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants