[refactor]Extract WindowNode.Specification as a separate class #25033
Conversation
...xecution/presto_cpp/presto_protocol/connector/arrow_flight/presto_protocol_arrow_flight.json
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.cpp
Outdated
Show resolved
Hide resolved
201bf92 to
37a1655
Compare
There was a problem hiding this comment.
Thanks @mohsaka
For the second commit on the protocol changes:
i) Change title to [native] Protocol changes for WindowNode.Specification
ii) Wanted to confirm that you generated the protocol changes using the instructions documented here : https://github.com/prestodb/presto/tree/master/presto-native-execution/presto_cpp/presto_protocol#presto-native-worker-protocol-code-generation
iii) Also, do you really want to separate the commit... Presto PRs do not squash commits before submission... So the build would be broken between the 2 commits.
There was a problem hiding this comment.
Lets separate this in its own PR. I can take that up.
Will combine the commits. Did follow those instructions, but provided by Christian directly not via the doc. But they were the same steps. |
| @@ -194,6 +194,7 @@ void from_json(const json& j, Storage& p); | |||
| } // namespace facebook::presto::protocol::hive | |||
| namespace facebook::presto::protocol::hive { | |||
| struct Table { | |||
| std::shared_ptr<String> catalogName = {}; | |||
There was a problem hiding this comment.
This change is picked up from #24235 looks like it only affects the metadata layer and not Prestissimo runtime. While it shouldn't affect any read/write behavior, is it ever used in error messages maybe ?
@majetideepak : Can you confirm
There was a problem hiding this comment.
If needed I can remove these changes from my PR.
Changes adapted from trino/PR#14175 Author: kasiafi Additional changes include: Presto protocol changes caused by Specification -> DataOrganizationSpecification change. Co-authored-by: kasiafi <[email protected]> Co-authored-by: mohsaka <[email protected]> Co-authored-by: Xin Zhang <[email protected]>
|
@aditi-pandit @ZacBlanco Issue opened here. Will post on the PR as well. |
Description
Extract WindowNode.Specification as a separate class to clean up TVF Porting PR which can be viewed here
#25032
Changes adapted from trino/PR#14175
Had to regenerate Presto Protocol due to renaming of Specification -> DataOrganizationSpecification.
Motivation and Context
WindowNode.Specification/DataOrganizationSpecification is utilized in table functions to store the order by and partition by properties for the table function. Therefore it is no longer WindowNode specific.
Impact
None.
Test Plan
No underlying changes.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.