Add resolved test cases #18358
Add resolved test cases #18358
Conversation
commit: |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tests/integration/cli/ignore-relative-path/level1-glob/α-shouldNotBeIgnored.js
Outdated
Show resolved
Hide resolved
2ddf655 to
fd13789
Compare
|
I consider #4460 (comment) is different problem from #4460. #4460 was caused by invalid use of |
| @@ -1,2 +1,3 @@ | |||
| level1/level2/ | |||
| level1-glob/**/level3-glob/*.js | |||
| α-shouldNotBeFormat.js | |||
There was a problem hiding this comment.
#6250 Seems talking about ignoring dir, but file inside not ignored.
There was a problem hiding this comment.
I remember we have a dir about special characters, maybe put there.
There was a problem hiding this comment.
This case looks to match the condition. Should I just revert fd13789?
https://github.com/prettier/prettier/blob/c60eca2415f86dbf6946874aff0427960b838f91/tests/integration/cli/special-characters-in-path/ignore-emoji/ignored/%E4%B8%AD%E6%96%87.js
There was a problem hiding this comment.
ignored directory is ignored. ignored/中文.js is a unicode character file in an ignored directory.
This reverts commit fd13789.
| .class { | ||
| flex-direction: column\${long_cond && long_cond && long_cond | ||
| ? "-reverse" | ||
| : ""}; |
There was a problem hiding this comment.
Yes, I missed to comment it. I consider ugly format is different problem from breaking CSS rule.
There was a problem hiding this comment.
Yes, I didn't ask you to solve 😄
fisker
left a comment
There was a problem hiding this comment.
Thank you for taking care of these old issues!
Description
Closes #8201, closes #4460, closes #4604, closes #5886, closes #6250
Checklist
I’ve added tests to confirm my change works.(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/directory).(If the change is user-facing) I’ve added my changes tochangelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.