Conversation
e06c329 to
3f350c8
Compare
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
| @@ -0,0 +1,6 @@ | |||
| // Test file for TypeScript config | |||
| const example = { foo: "bar", baz: 123, qux: true }; | |||
| // Test file for TypeScript config | ||
| const example = { foo: "bar", baz: 123, qux: true }; | ||
|
|
||
| function hello(name) { |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for all Prettier configuration file formats and addresses a monorepo plugin resolution issue. The changes consolidate TypeScript config testing under the general config test suite and add test fixtures for numerous config file types that were previously untested.
Key Changes:
- Expanded test coverage to include all Prettier config formats (.yml, .yaml, .toml, .json5, .mjs, .cjs, .ts, .mts, .cts variants)
- Added monorepo subfolder plugin resolution test (addressing Prettier issue #18353)
- Updated bundled Prettier from 3.7.1 to 3.7.3
- Added sponsors section to README
Reviewed changes
Copilot reviewed 63 out of 69 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/suite/config.test.ts | Expanded from 10 to 21 config format tests, added comments for each config type, removed trailing spaces and cspell comments |
| src/test/suite/monorepo-subfolder.test.ts | New test file for monorepo subfolder plugin resolution (issue #18353) |
| src/test/suite/ts-config.test.ts | Removed - functionality consolidated into config.test.ts |
| test-fixtures/config/{various} | Added 14 new config type test fixtures (yml, yaml, toml, json5, mjs, cjs, ts variants) |
| test-fixtures/config/tsconfigfile/ | Moved from test-fixtures/ts-config/, updated to use tabWidth: 5 for consistency |
| test-fixtures/monorepo-subfolder/ | New fixture demonstrating monorepo with subfolder having its own Prettier + plugins |
| test-fixtures/test.code-workspace | Replaced "ts-config" with "monorepo-subfolder" and "monorepo-subfolder/subfolder" |
| package.json | Bumped prettier dependency from 3.7.1 to 3.7.3 |
| package-lock.json | Updated lockfile for prettier 3.7.3 |
| README.md | Added sponsors section with Zuplo sponsorship |
Comment on lines
+1
to
+3
| function foo() { | ||
| console.log("test") | ||
| } |
There was a problem hiding this comment.
Unused function foo.
Suggested change
| function foo() { | |
| console.log("test") | |
| } |
Comment on lines
+1
to
+3
| function foo() { | ||
| console.log("test"); | ||
| } |
There was a problem hiding this comment.
Unused function foo.
Suggested change
| function foo() { | |
| console.log("test"); | |
| } |
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
There was a problem hiding this comment.
Unused function foo.
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
There was a problem hiding this comment.
Unused function foo.
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
There was a problem hiding this comment.
Unused function foo.
| @@ -0,0 +1,3 @@ | |||
| function foo() { | |||
There was a problem hiding this comment.
Unused function foo.
| @@ -0,0 +1,6 @@ | |||
| // Test file for TypeScript config | |||
| const example = { foo: "bar", baz: 123, qux: true }; | |||
There was a problem hiding this comment.
Unused variable example.
| // Test file for TypeScript config | ||
| const example = { foo: "bar", baz: 123, qux: true }; | ||
|
|
||
| function hello(name) { |
There was a problem hiding this comment.
Unused function hello.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional tests