Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Weakky
Copy link
Collaborator

@Weakky Weakky commented Jun 11, 2020

Enable the authorization plugin by default. Can be disabled via the settings.

TODO

  • docs
  • tests

[connectionTypeName: string]: ConnectionSettings | undefined | false
}
/**
* Disable or configure the authorization plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how to balance the difference between "go to this other place to read about a plugin" vs inline docs that may not even mention the plugin.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should have both. A shorten link that points to the full docs + an inline description that helps people in the 80% cases

Copy link
Member

@jasonkuhrt jasonkuhrt Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you see this differently than me but my view is this [pr] is 1) super needed 2) experimental stage (product wise). So, my feeling is we can keep things pretty raw for now, including docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same feeling. It's something along the lines of "I want it to be there but don't want to make too much noise about it yet".

@Weakky Weakky merged commit ec97f23 into master Jun 11, 2020
@Weakky Weakky deleted the feat/authorization-by-default branch June 11, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants