fix: prevent double reflection log #1210
Conversation
| // if there's already an execution, make it pending | ||
| pendingExecution = args | ||
| return null as any | ||
| return { type: 'executing' } |
There was a problem hiding this comment.
Wouldn't it be simpler to return a deferred promise here? Then the caller doesn't need to know about the inner workings between result/executing.
There was a problem hiding this comment.
What's a deferred promise in this case?
There was a problem hiding this comment.
Return a promise here, resolve it somewhere else later. (e.g. not within the promise func body)
There was a problem hiding this comment.
That won't work because promises are eager and we don't want that promise to run at all, until the one that is already running is finished. Otherwise we're not debouncing anything. We're just running the functions one after the other.
There was a problem hiding this comment.
Nevermind, that wouldn't help, because you need to dedupe higher up in the call stack.
| if (pendingExecution) { | ||
| await fn(...args).catch((e) => console.error(e)) | ||
| res = await fn(...args).catch((e) => console.error(e)) | ||
| pendingExecution = null | ||
| } |
There was a problem hiding this comment.
We do prefer it, hence why we run it right after the current promise is finished
Closes #1212