feat: apollo-server-express as default server
#1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo-server-express the default serverapollo-server-express the default server
eabac03 to
941ce28
Compare
941ce28 to
c5f4658
Compare
jasonkuhrt
approved these changes
Jul 22, 2020
apollo-server-express the default serverapollo-server-express as default server
Member
|
@Weakky sorry I converted this from [wip] pr title to semantic compatible b/c I thought the tests would pass. Converting this to a draft to try and restore what you were saying but without breaking conventional commit. |
|
Is this feat bumped to npm? |
Member
|
@krailler on canary now ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #981
TODO
Features:
BREAKING CHANGE:
Playground handler is removed
Nexus will serve GraphQL requests on this same path. Only client
GETrequests with theaccept: text/htmlheader will get back the Playground response.Playground settings no longer has the
endpointoption (as the playground is always hosted on the same path as the graphql api)Default path is changed from
/to/graphqlThis aligns with defaults in the Node GraphQL ecosystem. If you find this default annoying and would prefer it to remain
/please share that feedback!esModuleInteroprequiredThis is an artifact of the new
corsandwsdependencies. This shouldn't be a breaking change because Nexus will handle the tsconfig update for you in memory. But Nexus does not manually update the tsconfig on disk yet and so you will need to do that part yourself to remove the Nexus warning.