Thanks to visit codestin.com
Credit goes to github.com

Skip to content

improve: expose projectRoot setting in createTestContext #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasonkuhrt merged 3 commits into from
Aug 11, 2020
Merged

improve: expose projectRoot setting in createTestContext #1324

jasonkuhrt merged 3 commits into from
Aug 11, 2020

Conversation

@luhagel
Copy link
Contributor

@luhagel luhagel commented Aug 5, 2020 •
edited
Loading

Using createTestContext in a monorepo setting leads to the Layout.create function detecting the top level package.json and error out because that one doesn't have it's own name. However, by exposing the projectRoot option already accepted by Layout.create, we can circumvent this by resolving the path ahead of time, i.e.:

Object.assign(ctx, await originalCreateTestContext({ projectRoot: path.join(__dirname, '../..') }))

TODO

  • docs
    • jsdoc
    • website api
    • website guides
    • website tutorial
  • tests

@netlify
Copy link

netlify bot commented Aug 5, 2020 •
edited
Loading

Deploy request for graphql-nexus pending review.

Review with commit 3698db4

https://app.netlify.com/sites/graphql-nexus/deploys

jasonkuhrt
jasonkuhrt requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luhagel!

One thing. Can you add some jsdoc for this option, mainly about why this setting might be used (like the other).

@luhagel
Copy link
Contributor Author

luhagel commented Aug 7, 2020

Will do

@luhagel luhagel requested a review from jasonkuhrt August 8, 2020 21:59
jasonkuhrt
jasonkuhrt approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luhagel!

Clarifying question. The search for package.json starts from cwd by default. If you were inside your package root I don't think there should be any issue, right? However if you're trying to run tests for a package from the monorepo root, then indeed that will not work.

Just want to make sure I'm understanding the problem.

@luhagel
Copy link
Contributor Author

luhagel commented Aug 11, 2020 •
edited
Loading

@jasonkuhrt Exactly, the projectRoot and cwd work as expected if the command is started from the nexus package root.
In our example, we have a monorepo with a few packages of which the api package is one.

Our Jest suite runs from the monorepo root and executes all the suites across all the packages via jest projects.

Since the yarn test command gets kicked off from the monrepo root, cwd resolves to the top level package.json instead of the one in packages/api, which leads to errors to parsing since workspace roots miss some fields and the plugins are defined i the package root so reflection breaks.

@jasonkuhrt jasonkuhrt merged commit ddfe403 into prisma-labs:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luhagel @jasonkuhrt