feat(tslsp): exclude autocompletions from private api #912
Conversation
This change introduces a TypeScript Langauge Service.
It needs to be used in the tsconfig like so:
```ts
{
"compilerOptions": {
"plugins": [{ "name": "nexus/typescript-language-service" }]
},
}
```
Nexus will automate management of this config, ensuring:
1. If present, that it is correctly configured
2. If not present, added
|
I'm not sure I'm going to test this. It's probably going to double the work needed for this PR. Because its so simple for now I think we can opt to revisit system testing with TS language server plugin later. For docs we should mention what this plugin does in the project layout (which is where most of our tsconfig interop doc lives today) Still have to write the tsconfig auto-management logic. |
Weakky
left a comment
There was a problem hiding this comment.
That looks awesome, great work! 💯
|
🙏 In the end I'm skipping the tsconfig automation. Sticking to our current lint system. I'll open an issue about having Nexus actually write the tsconfig when it drifts from what it should be, rather than just warnings that users need to manually respond to. Basically what Nextjs is doing. |
This change introduces a TypeScript Langauge Service.
It needs to be used in the tsconfig like so:
Nexus will automate management of this config, ensuring:
Before / After this change:
Server
Settings
log
closes #...
TODO
testsin the future, see comment below.