Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow alert() messages #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crhallberg opened this issue Jan 29, 2018 · 3 comments
Closed

Allow alert() messages #507

crhallberg opened this issue Jan 29, 2018 · 3 comments
Labels
Feature Request Proposal for adding a new functionality Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:Low Low-impact issue that can be addressed after higher-priority tasks

Comments

@crhallberg
Copy link

I've noticed that you cannot use alert() inside of sketches. This seems to be due to the sandboxing of the iframe and the lack of allow-modals which has been referred to in previous issues (#2360).

I'm assuming this is intentionally omitted to prevent printing, but based on what I read in Issue 474 using print() outside of functions to actually print is the intended design. With allow-modals, print is still successfully sandboxed inside of functions and alerts work properly.

I can make a pull request, but I wanted to make sure this was a good direction to go in before I do so.
@catarak
Copy link
Member

catarak commented Feb 6, 2018

makes sense to me to remove this from the sandboxing of the iframe. go ahead and change it!

@catarak catarak added Feature Request Proposal for adding a new functionality Priority:Low Low-impact issue that can be addressed after higher-priority tasks Help Wanted Would love additional input or contributions! Good First Issue A beginner-friendly issue, great for first-time contributors labels Feb 6, 2018
@crhallberg crhallberg mentioned this issue Feb 6, 2018
Merged
catarak pushed a commit that referenced this issue Feb 7, 2018
@catarak
Add allow-modals to iframe, allowing alert and prompt. Discussed in I…
62670e6 
…ssue #507. (#518)
@jareddonovan
Copy link
Contributor

Should this issue be closed following the merge of crhallberg's commit?

@catarak
Copy link
Member

catarak commented Apr 13, 2018

definitely! closing this 🌈

@catarak catarak closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Proposal for adding a new functionality Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:Low Low-impact issue that can be addressed after higher-priority tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jareddonovan @crhallberg @catarak