Fix colors of the errors in the console in Contrast and dark mode.(#2046) #2100
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Release EnvironmentsThis pull request environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-b19c03bced |
There was a problem hiding this comment.
Thank you so much for working on this, and for your patience as we review these issues—I think overall this looks great!
Before it's ready to go, I think there's a few more edits that could be added:
1.) Removing the "!important" property from the lines I commented on since it seems to be affecting the color scheme of the play/pause buttons (pictured below).
How it looks right now:
Original:
2.) Re-inserting the .env.example file, which has currently been removed
Thanks again and super excited to see this out soon! :)
|
|
||
| & g, | ||
| & path { | ||
| fill: getThemifyVariable('inactive-text-color') !important; |
There was a problem hiding this comment.
I would remove the "!important" for the path property, since it's affecting the color scheme for the play/pause button!
|
|
||
| & g, | ||
| & path { | ||
| fill: getThemifyVariable('heavy-text-color') !important; |
|
Thank you so much for your efforts on this! This was ultimately resolved by #2156, so I'm going to close this for now. :) |
Fixes #2046
Changes:
I have added an important tag to all the modes. After which it is looking like this in contrast mode
While hovering over the link will look like this
I have verified that this pull request:
[☑] has no linting errors (
npm run lint)[ ] has no test errors (
npm run test)[☑] is from a uniquely-named feature branch and is up to date with the
developbranch.[☑] is descriptively named and links to an issue number, i.e.
Fixes #2046