-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create text output for canvas #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
httpRequest.open('GET', path,false); | ||
httpRequest.send(); | ||
} | ||
fetchJSONFile('https://raw.githubusercontent.com/processing/p5.js-website/9f1a4cd299c1330b046373407d42894e274d20e7/reference/data.min.json', function(data){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't rely on serving a file from Github. You could put this file in the static directory, and then parse that, or, maybe it an API endpoint that serves this JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll move both the files to the static folder
Also, any ideas, from a UI/UX perspective, on the Lint Warning Sound and Text Output preference options? If a user doesn't have a screen reader and has these options on, he or she may be confused because nothing is happening. Is there a way to denote that you need a screen reader in order to use these features? |
How about a heading within preferences that says 'Accessibility options' ? And maybe some way to read more on it? ( a drop down text or a link to some documentation) Or since the lint warning beeps even without a screen reader, we can probably change the text from 'Hidden text output' to 'accessible canvas - used with screen reader' ? @CleezyITP - what do you think of this? |
@omnikrll is working on lint warning preferences atm. We talked about having a drop down for tone options and I think it would be great to link to further accessibility documentation. Picking up this work some more this weekend! I would love for the text output to be the default and have it be an option to turn it off for optimization...That option aside, I think that calling it 'accessible text-based canvas' is most appropriate given the unique feature for screen reader and the research from American Foundation for the Blind (2016) regarding the issue of separate screen reader (SR) or "textonly" versions vs. accessibility of default site: "Most users told us they do not appreciate having a separate SR or "text only" version of a site. They were concerned that they might not be getting the same thing as the default site, and that it might not be updated as regularly. Those who did appreciate the "SR version," because of its |
Okay, makes sense. As much as I would like to have the text output on by default, I think it will be too sluggish sometimes for users not using screen readers. I like 'accessible text-based canvas'. For now, though this is an imperfect solution, can I just add a header for those options, something like "Accessible Enhancements", after I merge in this PR? Just to make something clear for users not using screen reader, and then in another PR we can improve the UI/UX for accessible users. |
I agree that it could be sluggish at times which is why it should be made easy to turn off as possible. Maybe a pop-up that reads "The Processing Foundation supports accessibility, so enhanced accessibility options have been turned on by default. If you would like to turn these off to optimize performance CLICK HERE". This has been an issue at the forefront of efforts like this in the past and since the beginning of the work with p5. |
Considering we can also turn on the text output using the play button (the hidden one), would it be as much of an issue if we keep it off in preferences? |
Ah @MathuraMG, thanks. Yes, sorry @catarak was confused by the 'default' word. As long as it is the default when screenreader users press play, no problem. I was just thinking it would be counter to the effort of accessibility if we made people search for the feature to turn it on. |
@MathuraMG I think the best option, for now is to keep the text output option out of preferences, and have the hidden play button for screen readers always have the text canvas. Seems like a happy medium, yes? |
@CleezyITP , @catarak |
@MathuraMG I'm okay with it. Want to add that to this PR and then I'll merge? |
This PR creates a text output for the canvas. This involves the following elements -
intercept-p5.js
andinterceptor-functions.js
contains the functions that run the monkey patch on the existing p5 functions. They are being included inPreviewFrame.js
loadData.js
is another static file that is being used to load thedata.json
file from the following location(cc @lmccart )Below picture shows all elements (screenshot is before they were hidden)

(cc @CleezyITP)