Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

madair
Copy link
Contributor

@madair madair commented Sep 24, 2013

implements the Eckert VI projection - to close svn ticket 87

@calvinmetcalf
Copy link
Member

can you do it with wkt strings instead of proj4 strings? We need to make sure that we can corectly parse what both ogc and esri call the values.

@calvinmetcalf
Copy link
Member

also you need to add Eckert_VI to the names array.

@madair
Copy link
Contributor Author

madair commented Sep 24, 2013

No sorry I don't have any WKT strings for this one.

Which names array? Isn't that what the projections.js file does?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Eckert_VI to this array

@madair
Copy link
Contributor Author

madair commented Sep 24, 2013

I'm not sure I understand, it is added to the array on line 21. Is there a requirement for the underscore?

@calvinmetcalf
Copy link
Member

yes the underscore is treated distinctly from a space

@madair
Copy link
Contributor Author

madair commented Sep 24, 2013

ok I'll change it, UTM needs to be fixed then because I copied the style form there.

@calvinmetcalf
Copy link
Member

you don't need to change it, you can have both in there with and without the space, I'm insisting on the underscore because that's how wkt describes it.

@madair
Copy link
Contributor Author

madair commented Sep 24, 2013

added the WKT strings but tests are failing with the same error as the proj strings before I added +datum=none as a param.

@calvinmetcalf
Copy link
Member

adding the following line to the end of the cleanWKT function in the wkt file gets the tests to pass, but it does so by turning off datums for all sinusudal and eck6 projections, will they never have datums ?

if(['eck6',"Eckert_VI","sinu","Sinusoidal"].indexOf(wkt.PROJECTION)>-1){
    wkt.datumCode = 'none';
}

@calvinmetcalf
Copy link
Member

so it looks like the general issue is just that sphere and none should be the same but aren't. Bear in mind that that I am not confident which of the two miller cylindrical version is correct

@madair
Copy link
Contributor Author

madair commented Sep 25, 2013

yes I think it's much safer to just set datum=none when looking for the "not_specified_based_on_authalic_sphere" rather than disabling datum transformations for that whole class of projections. There are probably other datum identifiers that should equate to datum=none and this filter can be expanded as required.

@calvinmetcalf
Copy link
Member

it looks like datum=none and datum=sphere might actually mean the same thing

@rotsee
Copy link

rotsee commented Jan 3, 2018

What is still needed to implement this?

@calvinmetcalf
Copy link
Member

a refactor probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants