Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[263] Release Action can skip intermediate steps #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

[263] Release Action can skip intermediate steps #306

merged 1 commit into from
Sep 27, 2023

Conversation

jiripetrlik
Copy link
Contributor

Closes #263
It was necessary to use only one additional parameter for the list of released components because Github allows only 10 workflow parameters. I was also forced to use "if" for steps instead of jobs. It is because if I skip the job then all dependent jobs are also skipped which is not desirable.

Example runs (all bash code was commented out to not perform real release):

@jiripetrlik jiripetrlik removed the request for review from jbusche September 25, 2023 14:15
@sutaakar
Copy link
Contributor

@jiripetrlik What about using a different logic here - if component version is not defined then we can consider component build to be skipped?
That would also require to adjust the release workflow in components to make their dependencies optional too.

What do you think about it?

@jiripetrlik
Copy link
Contributor Author

@sutaakar
I've changed it in the way we discussed yesterday. Release of component will be triggered only if it doesn't exist yet.

Test runs:

sutaakar
sutaakar reviewed Sep 27, 2023
View reviewed changes
sutaakar
sutaakar reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2023
anishasthana
anishasthana approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3bf1ba8 into project-codeflare:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@sutaakar sutaakar sutaakar left review comments

@anishasthana anishasthana anishasthana approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sutaakar sutaakar

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Release Action to support skipping of intermediate steps
4 participants
@jiripetrlik @sutaakar @anishasthana @openshift-merge-robot