Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support records in upcoming eclipse version #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2025
Merged

Support records in upcoming eclipse version #3888

merged 4 commits into from
Aug 7, 2025

Conversation

Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented May 27, 2025

This PR fixes #3883

Eclipse changed how they handle records. Instead of generating fields early on it now does it in a later stage. To keep the support in lombok we now map the record components to fields ourself and add theses fields to our AST. To keep the test output the same I added a patch that removes the implicit fields from the output if they are present.

rgrunber
rgrunber approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out and it works well for me. Records with a @Builder annotation no longer emit an error. "Document does not match AST" also remains fixed.

@rgrunber rgrunber mentioned this pull request May 28, 2025
Closed
@durvalprintes
Copy link

I built the branch and tested the new jar, the errors disappeared.

@rgrunber rgrunber mentioned this pull request Jun 9, 2025
Closed
rgrunber added a commit to rgrunber/vscode-java that referenced this pull request Jun 24, 2025
@rgrunber
Add custom Lombok 1.18.39 snapshot into lombok folder.
afe36ce 
- Base version projectlombok/lombok@94b01e4 along with unmerged fix from
  projectlombok/lombok#3888

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber mentioned this pull request Jun 24, 2025
Merged
rgrunber added a commit to rgrunber/vscode-java that referenced this pull request Jun 24, 2025
@rgrunber
Add custom Lombok 1.18.39 snapshot into lombok folder.
9d42195 
- Base version projectlombok/lombok@94b01e4 along with unmerged fix from
  projectlombok/lombok#3888

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber added a commit to rgrunber/vscode-java that referenced this pull request Jun 24, 2025
@rgrunber
Add custom Lombok 1.18.39 snapshot into lombok folder.
02e11d6 
- Base version projectlombok/lombok@94b01e4 along with unmerged fix from
  projectlombok/lombok#3888

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber added a commit to redhat-developer/vscode-java that referenced this pull request Jun 24, 2025
@rgrunber
Add custom Lombok 1.18.39 snapshot into lombok folder.
acb44d7 
- Base version projectlombok/lombok@94b01e4 along with unmerged fix from
  projectlombok/lombok#3888

Signed-off-by: Roland Grunberg <[email protected]>
@hashpyrit
Copy link

hashpyrit commented Jul 7, 2025 •
edited
Loading

The problem still occurs if you you do custom constructor field validation for your record:

public record FailedEvent(Long assetId, DigitalAssetIdentifier assetIdentifier, @NonNull String user, String failureMessage) {

    @Builder <--- this line gets the error that the constructor is not defined
    public FailedEvent {
        if (assetId == null && assetIdentifier == null) {
            throw new IllegalArgumentException("Either assetId or assetIdentifier must be provided");
        }
    }
}

I downloaded lombok-edge.jar today as well as I tried the lombok-1.18.39-4050.jar. Fails with both. I'm using Spring Tools For Eclipse 4.31.0 which is using Eclipse JDT 3.20.200.v20250528-1830.

@vkushnir-onseo
Copy link

Hello! Dear @Rawi01 just cloned this branch, run ant dist and tried generated jar with eclipse and issue still there. Few possible cases: I did smth wrong or fix is not complete or eclipse again changed logic related to records handling

Version: 2025-06 (4.36.0)
Build id: 20250605-1316
Lombok v1.18.37 "Edgy Guinea Pig" - 2025-07-09 is installed. https://projectlombok.org/

@nimo23 nimo23 mentioned this pull request Jul 9, 2025
Open
@Rawi01
Copy link
Collaborator Author

Rawi01 commented Jul 9, 2025

@vkushnir-onseo This branch should generate a build of version 1.18.39. You either built the wrong branch or made a mistake in your eclipse setup. Rather than building it yourself, you can also download the artifact from the GitHub Actions run. (https://github.com/projectlombok/lombok/actions/runs/15284242422?pr=3888)

@alphademirkaya-hub
Copy link

@Rawi01 thanks a lot it works!

rzwitserloot
rzwitserloot reviewed Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@rzwitserloot rzwitserloot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawi01 Without spending some time delving into why we added 'hey if you see TerminalToken being loaded, apply this patch' is no longer needed – trying to get a grip on why we can simply the fixing of dom.rewrite.TokenScanner. Can you confirm we no longer need it / OSGI check takes care of it?

For context: Up to ~3 months ago, this fix was only applied if we witnessed TerminalToken. 3 months ago, this was updated to 'either if you see any OSGI signs or if you see TerminalToken, apply it' and now we've arrived at: "If you see any OSGI signs, apply it. Don't worry about TerminalToken".

EDIT: Hmm, not sure github makes it possible to see what this is referring to. It's about commit 'Use simpler addScriptIfWitness', 98d980d.

@rzwitserloot rzwitserloot merged commit 7aa264e into projectlombok:master Aug 7, 2025
59 checks passed
@rgrunber
Copy link
Contributor

rgrunber commented Aug 7, 2025

@rzwitserloot I think that commit was related to #3885 (comment) . Upstream replaces TerminalTokens with TerminalToken in newer versions. I think the logic should be "if you see TerminalToken, we're using a newer Eclipse runtime, so apply the patch".

@hashpyrit hashpyrit mentioned this pull request Aug 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzwitserloot rzwitserloot rzwitserloot left review comments

+1 more reviewer

@rgrunber rgrunber rgrunber approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] @Builder annotation broken with Java records
7 participants
@Rawi01 @durvalprintes @hashpyrit @vkushnir-onseo @alphademirkaya-hub @rgrunber @rzwitserloot