Fixes #1431 - shaded exposition-formats/exported-opentelemetry #1441
Conversation
Fixes #1431 issue, where shaded exposition-formats/exported-opentelemetry artifacts depends on "no shaded" protobuf/otel dependency (caused by #1293). Signed-off-by: Radek Kraus <[email protected]>
944945a to
9ab4203
Compare
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.prometheus</groupId> | ||
| <artifactId>prometheus-metrics-exporter-opentelemetry-no-otel</artifactId> |
There was a problem hiding this comment.
This dependency also has java classes that are missing now
There was a problem hiding this comment.
I am sorry, but I didn't catch the point.
The classes from prometheus-metrics-exporter-opentelemetry-no-otel artifact (module directory prometheus-metrics-exporter-opentelemetry) are copied by maven-resources-plugin (see execution copy-metrics-exporter-opentelemetry-main) and then are relocated by maven-shade-plugin.
I see all classes (using correct "shaded" import statements) in io.prometheus:prometheus-metrics-exporter-opentelemetry artifact.
There was a problem hiding this comment.
now I get it - that's a really nice solution!
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.prometheus</groupId> | ||
| <artifactId>prometheus-metrics-exposition-formats-no-protobuf</artifactId> |
There was a problem hiding this comment.
This dependency also has java classes that are missing now
There was a problem hiding this comment.
I am sorry, but I didn't catch the point.
The classes from prometheus-metrics-exposition-formats-no-protobuf artifact (module directory prometheus-metrics-exposition-formats) are copied by maven-resources-plugin ( see execution copy-metrics-exposition-formats-main) and then are relocated by maven-shade-plugin.
I see all classes (using shaded correct "shaded" import statement) in io.prometheus:prometheus-metrics-exposition-formats artifact.
Fixes #1431 issue, where shaded exposition-formats/exported-opentelemetry artifacts depends on "no shaded" protobuf/otel dependency (caused by #1293).
See details in #1431 issue.