Convert MetricFamily labels -> list #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem like the right fix, this should be down in GaugeMetricFamily I think. Also a unittest would be good. |
|
Do you mean GaugeMetricFamily should ensure labels is a list of strings in |
|
Yes |
|
@brian-brazil I've force-pushed away the original commit, and converted labelnames to a tuple in all MetricFamilies |
|
Thanks! |
|
Yay, thanks for this PR. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3 the labels of the
python_infometric is a reference to thedict_keysof the data object used to create it. This PR ensures all labelnames in MetricFamilies it are a static tuple instead.This PR is motivated by some broken tests in https://github.com/korfuri/django-prometheus with recent versions of prometheus-client: django-commons/django-prometheus#46 (comment)
Although the docs do not say Metrics should be serializable this change seems more in keeping with the intention that labels should be owned by the Metric and not a reference to an external object.