Code style fixups #325
Merged
Code style fixups #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aarni Koskela <[email protected]>
|
You have a build failure. |
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
|
Ah yeah. Old Pythons don't like trailing commas in argument lists. Fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some wonky indentation (there were occasions of non-4-divisible indentation 😱 ) both mechanically (
autopep8) and by hand where manually rewrapping code lead to more readable statements. (That, too, could be automated with something likeblack.)In addition, there were some duplicate imports, which were cleaned up with
isort. Asetup.cfgfile was added to configure the multi-line import style to match the one most used in the project.