State that Summary does not support quantiles #36
Conversation
| @@ -142,6 +142,8 @@ with s.time(): | |||
| pass | |||
| ``` | |||
|
|
|||
| **Summary support is incomplete**. The python client doesn't store or expose quantile information at this time. | |||
There was a problem hiding this comment.
That's a bit strong, this is a complete client library per the spec. I'd remove the first sentence.
|
I've probably missed something then. From the docs I was expecting Summary to expose:
But indeed, the Guidelines document does mention the client libraries are only encouraged to expose quantiles. From my humble understanding either the docs should be more flexible, or the libraries very strict. @brian-brazil what do you think? |
|
The docs need to be relaxed, using summaries without quantiles should be much more common than using them with (quantiles are quite expensive). |
|
Nice, do you recommend opening a PR on the docs then? I've removed the incomplete part and renamed this PR. |
| @@ -142,6 +142,8 @@ with s.time(): | |||
| pass | |||
| ``` | |||
|
|
|||
| The python client doesn't store or expose quantile information at this time. | |||
There was a problem hiding this comment.
We're capitalising Python elsewhere, can you do the same for consistency?
dc612ed to
1ffb41d
Compare
| @@ -142,6 +142,8 @@ with s.time(): | |||
| pass | |||
| ``` | |||
|
|
|||
| The Python Client doesn't store or expose quantile information at this time. | |||
There was a problem hiding this comment.
We don't capitalise client :(
State that Summary does not support quantiles
No description provided.