Fix Package Name typo in pip install instructions #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current instructions seem to work for me, are you sure this is broken? |
This is probably due to the fact that pypi automatically converts the _ to - since both of these links work: However when you are using a tool wihtout this logic like pycharm you do not find the package that you are looking for if you input the _ |
Change package name in pip install instructions to match pypi with - instead of _ Signed-off-by: Norman Gehrsitz <[email protected]>
|
Thanks! I don't see a problem here, but we should be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change package name in pip install instructions to match pypi with - instead of _