Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make tests pass on Python 2.6 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Make tests pass on Python 2.6 #89

merged 1 commit into from
Jul 14, 2016

Conversation

hynek
Copy link
Contributor

@hynek hynek commented Jul 8, 2016

As discussed in #86, this adds Python 2.6 support for the tests and CI.

Since 2.6’s stdlib doesn’t support test skipping, we have to resort to using the back port unittest2.

There are a few ways to make it less ugly:

  • use unittest2 unconditionally everywhere. has also the benefit of a consistent test environment.
  • do the dance once in a helper module (say tests/utils.py) and then just import unittest from there.
  • use pytest for skipping

@brian-brazil brian-brazil merged commit bc2f2bc into prometheus:master Jul 14, 2016
@brian-brazil
Copy link
Contributor

Having anyone on 2.6 have to install an extra module for testing seems fine to me.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants