Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix proxyConnectHeader type in ScrapeConfig #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix proxyConnectHeader type in ScrapeConfig #6531

wants to merge 1 commit into from

Conversation

dongjiang1989
Copy link
Member

@dongjiang1989 dongjiang1989 commented Apr 19, 2024 •
edited
Loading

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Fix proxyConnectHeader type in ScrapeConfig

fixes: #6523

link: #6527

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Fix proxyConnectHeader type in ScrapeConfig

@dongjiang1989 dongjiang1989 requested a review from a team as a code owner April 19, 2024 05:17
@dongjiang1989 dongjiang1989 mentioned this pull request Apr 19, 2024
Merged
5 tasks
@dongjiang1989
Copy link
Member Author

cc @slashpai @simonpasquier PTAL

@simonpasquier
Copy link
Contributor

Thanks for fixing it! After more thinking I realize that we misrepresented the ProxyConnectHeader field.

Prometheus config says that it's a map[string][]string while the CRD field is equivalent to a map[string]string. Given that ScrapeConfig is v1alpha1 and that ProxyConnectHeader has a niche usage, I'd be inclined to "fix" the CRD now but it has to wait for the next minor release.

@prometheus-operator/prometheus-operator-reviewers thoughts?

@dongjiang1989
Copy link
Member Author

If the CRD field changes from map[string]string to map[string][]string, this is a breaking change and will cause existing functionality to not work.

Waiting for the next minor release. +1

@dongjiang1989 dongjiang1989 mentioned this pull request Apr 22, 2024
Merged
5 tasks
@slashpai
Copy link
Contributor

Since we are not doing it for patch release I am closing this one since you have already opened another PR #6541

@slashpai slashpai closed this Apr 23, 2024
@dongjiang1989
Copy link
Member Author

Since we are not doing it for patch release I am closing this one since you have already opened another PR #6541

Thanks

@dongjiang1989 dongjiang1989 deleted the fix-proxy-connect-header branch May 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashpai slashpai slashpai approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongjiang1989 @simonpasquier @slashpai