Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

heliapb
Copy link
Member

@heliapb heliapb commented Jul 29, 2025

Description

Add support for Thanos Rule --enable-feature=promql-experimental-functions available on 0.39.0 onwards.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


@heliapb heliapb requested a review from a team as a code owner July 29, 2025 22:09
@simonpasquier
Copy link
Contributor

I'd rather add the enableFeatures field like we did for Prometheus.

@heliapb heliapb force-pushed the feat_rule_enable_feature branch from b6c59f3 to f99ef4d Compare July 30, 2025 09:39
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 30, 2025
@heliapb
Copy link
Member Author

heliapb commented Jul 30, 2025

I'd rather add the enableFeatures field like we did for Prometheus.

Thanks @simonpasquier changed as suggested.

@heliapb heliapb requested a review from simonpasquier July 30, 2025 13:35
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit otherwise lgtm

heliapb added 4 commits July 30, 2025 21:42
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
@heliapb heliapb force-pushed the feat_rule_enable_feature branch from a817eb0 to 4711f9f Compare July 30, 2025 20:50
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit bf439d4 into prometheus-operator:main Jul 31, 2025
23 checks passed
@heliapb heliapb deleted the feat_rule_enable_feature branch July 31, 2025 08:57
miinsun pushed a commit to miinsun/prometheus-operator that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants