Feat: set Azure Manage Identity Client ID default to empty value #7815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The client id to be used with Azure AD Managed Identity | ||
| // For Prometheus >= 3.5.0, this field is allowed to be empty to support system assigned managed identity. | ||
| // +optional | ||
| ClientID string `json:"clientId"` |
There was a problem hiding this comment.
Suggested change
| ClientID string `json:"clientId"` | |
| // +kubebuilder:validation:MinLength:=1 | |
| ClientID *string `json:"clientId"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the new feature introduced in the Prometheus 3.5.0, the field client_id under Azure AD Managed Identity in Remote Write is allowed to be the blank support system assigned managed identity. This PR changes the ClientID field to be optional and will place the empty string in the config when the field is not being set.
Fixes #7562
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Unit Testing
Changelog entry