feat: add remaining CEL validations #7881
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slashexx <[email protected]>
There was a problem hiding this comment.
Sorry about the delays.
Looks good to me for the most part, just one nit.
CC: @slashpai
Comment on lines
+895
to
+902
| _, err := framework.CreateOrUpdatePrometheusOperatorWithOpts( | ||
| ctx, testFramework.PrometheusOperatorOpts{ | ||
| Namespace: ns, | ||
| AllowedNamespaces: []string{ns}, | ||
| EnabledFeatureGates: []operator.FeatureGateName{operator.PrometheusAgentDaemonSetFeature}, | ||
| }, | ||
| ) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
It isn't problematic, but we likely don't need to set up the operator to test just the CEL rules. I would be fine with removing this as well.
There was a problem hiding this comment.
I might be wrong though, so you may want to test it out first :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the remaining CEL validations for fields which were missing before.
Important to note that these fields are yet to be finalised and await merge of #7571
Closes: #7880
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.