Add usefips #7894
Draft
Add usefips #7894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliapb
reviewed
Sep 9, 2025
Comment on lines
+1862
to
+1864
| // UseFIPSSTSEndpoint enables FIPS mode for AWS STS endpoint. | ||
| // +optional | ||
| UseFIPSSTSEndpoint *bool `json:"useFipsSTSEndpoint,omitempty"` |
There was a problem hiding this comment.
Suggested change
| // UseFIPSSTSEndpoint enables FIPS mode for AWS STS endpoint. | |
| // +optional | |
| UseFIPSSTSEndpoint *bool `json:"useFipsSTSEndpoint,omitempty"` | |
| // useFIPSSTSEndpoint defines FIPS mode for AWS STS endpoint. | |
| // +optional | |
| UseFIPSSTSEndpoint *bool `json:"useFIPSSTSEndpoint,omitempty"` |
Hi @mohammed-uddin small nit. Also you need to run make --always-make format generate to update docs.
3e8fa8b to
a1727f4
Compare
| } | ||
|
|
||
| if sigv4.UseFIPSSTSEndpoint != nil { | ||
| sigv4Cfg = append(sigv4Cfg, yaml.MapItem{Key: "use_fips_sts_endpoint", Value: *sigv4.UseFIPSSTSEndpoint}) |
There was a problem hiding this comment.
we would need to check the version of Prometheus to ensure that it supports the field (not sure in which version it was introduced).
Unrelated but it seems that the option isn't documented: https://prometheus.io/docs/prometheus/latest/configuration/configuration/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes an existing issue (bug or feature), use the following keyword:
Closes: #ISSUE-NUMBER
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.