feat: add status subresource to PrometheusRule CRD #7935
Conversation
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
|
For PrometheusRule and AlertmanagerConfig we need different struct for status, i guess because in future we are having targets information in the current struct |
|
the current struct which is ConfigResourceStatus is only for smon, podmon and probes, |
|
also add |
|
While we have stability guarantees for CRDs, we don't have for the Go structs so I would reuse the same struct for now. We'll refactor when/if we need new fields for scrape-based resources. The only change that I would see is to relax the validation marker on the resource field (right now, it is |
|
ok, then ! @heliapb also change the comments whenever necessary in the structs to include PrometheusRule as config and thanosruler as workload |
Description
From issue #7922
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.