Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate assignments to rc configurator #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lukelbd
Copy link
Collaborator

@lukelbd lukelbd commented Jan 10, 2020

This will address #69. Includes some pretty major changes but is currently broken; will force push and break up into smaller commits on some later date.

Edit: I think the best approach may be to entirely subclass/replace RcParams, monkey patch matplotlib.rcParams, and simply have proplot.rc point to matplotlib.rcParams. This will let me implement some other features, e.g. arbitrary units for matplotlib params with conversion upon calling RcParams.__getitem__, and keeps me from having to store separate dictionaries. The sections on the website docs will instead read "Shorthand params" and "rcParams additions"; the former will be implemented only in RcParams.__setitem__, and the latter will be literally added as valid matplotlib.rcParams. This will be yet another exercise in integrating proplot's internals more closely with the matplotlib API; wish I had looked at the matplotlib source code more in the early days of development.

@lukelbd lukelbd added this to the Version 0.8 milestone Jul 21, 2021
@lukelbd lukelbd closed this Aug 9, 2021
@lukelbd lukelbd deleted the rc-assignment-validation branch August 9, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant