Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clean up rc_configurator #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 7, 2020
Merged

Clean up rc_configurator #91

merged 34 commits into from
Jan 7, 2020

Conversation

lukelbd
Copy link
Collaborator

@lukelbd lukelbd commented Dec 19, 2019

This will implement changes to rc_configurator that were for some reason included in #50. It will also fix the fatal rc.context bug described in #80. Details to come.

@lukelbd
Copy link
Collaborator Author

lukelbd commented Jan 7, 2020

This PR makes the context behavior more sane -- now, nesting is allowed, and if you want rc_configurator to return None for a setting when it has not been changed inside the latest context block, you have to use the special rc_configurator functions get, category, and fill with context=True. The old "feature" where __getitem__ can return None would have been baffling for most users.

It also adds a _get_space function so that default gridspec spacing is determined from the axpad, panelpad, and pad settings, and the current font size, tick length, and padding settings, which let me eliminate these clunky subplots.ylabspace, subplots.xlabspace, etc. settings. It also adds [x|y][gridcolor|linewidth] keyword arguments to format, which is something that should never have been included in #50.

@lukelbd lukelbd merged commit 2289bcc into master Jan 7, 2020
@lukelbd lukelbd deleted the rc-cleanup-fixes branch January 7, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant