feat: automate publishing releases to Bazel Central Registry #16014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, recent releases on the BCR have a patch set applied, and it seems these patches are developed independently to "fix" each protobuf release, rather than make changes to protobuf repo. The effect of this PR will be to create a *broken* publish to BCR for each protobuf release. At least this red PR on BCR will be our indication that the patches need to be manually replayed there. In parallel, starting with #16013 I'll apply as many of those patches to the protobuf repo as possible. That will reduce the manual effort for each release.
alexeagle
added a commit
to bazelbuild/rules_proto
that referenced
this pull request
Mar 4, 2024
This allows rules_proto to supply a pre-built binary toolchain for protoc without needing any Bazel module supplied by the protocolbuffers maintainers. Obviates the need for protobuf to be released to the BCR as in protocolbuffers/protobuf#16014 Allows the protocolbuffers team to stop caring about Bazel builds for external users, and to close associated bugs. Next step in rules_proto supplying a toolchain that doesn't require users build protoc from sources.
alexeagle
added a commit
to bazelbuild/rules_proto
that referenced
this pull request
Mar 4, 2024
This allows rules_proto to supply a pre-built binary toolchain for protoc without needing any Bazel module supplied by the protocolbuffers maintainers. Obviates the need for protobuf to be released to the BCR as in protocolbuffers/protobuf#16014 Allows the protocolbuffers team to stop caring about Bazel builds for external users, and to close associated bugs. Next step in rules_proto supplying a toolchain that doesn't require users build protoc from sources.
alexeagle
added a commit
to bazelbuild/rules_proto
that referenced
this pull request
Mar 4, 2024
This allows rules_proto to supply a pre-built binary toolchain for protoc without needing any Bazel module supplied by the protocolbuffers maintainers. Obviates the need for protobuf to be released to the BCR as in protocolbuffers/protobuf#16014 Allows the protocolbuffers team to stop caring about Bazel builds for external users, and to close associated bugs. Next step in rules_proto supplying a toolchain that doesn't require users build protoc from sources.
mkruskal-google
approved these changes
Mar 9, 2024
zhangskz
reviewed
Mar 11, 2024
zhangskz
approved these changes
Mar 11, 2024
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…lbuffers#16014) Note, recent releases on the BCR have a patch set applied, and it seems these patches are developed independently to "fix" each protobuf release, rather than make changes to protobuf repo. The effect of this PR will be to create a *broken* publish to BCR for each protobuf release. At least this red PR on BCR will be our indication that the patches need to be manually replayed there. In parallel, starting with protocolbuffers#16013 I'll apply as many of those patches to the protobuf repo as possible. That will reduce the manual effort for each release. Replaces protocolbuffers#14565 which originated from my fork so the tests wouldn't run. Closes protocolbuffers#16014 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16014 from protocolbuffers:bcr e17d9c8 PiperOrigin-RevId: 615026796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, recent releases on the BCR have a patch set applied, and it seems these patches are developed independently to "fix" each protobuf release, rather than make changes to protobuf repo.
The effect of this PR will be to create a broken publish to BCR for each protobuf release. At least this red PR on BCR will be our indication that the patches need to be manually replayed there.
In parallel, starting with #16013 I'll apply as many of those patches to the protobuf repo as possible. That will reduce the manual effort for each release.
Replaces #14565 which originated from my fork so the tests wouldn't run.