mix_stderr parameter was removed from click 8.2.0 #4577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
|
Also, wouldn't this change make the entire class redundant? |
|
Yes, seems like we may have to make this conditional on Click version. |
|
Ok, I will try to make it conditional 🙂 |
|
sorry, I couldn't think of a more pythonic way |
JelleZijlstra
approved these changes
Feb 14, 2025
zbkash
approved these changes
Feb 14, 2025
zbkash
approved these changes
Feb 14, 2025
MeGaGiGaGon
reviewed
Feb 14, 2025
tests/test_black.py
Outdated
|
|
||
| def __init__(self) -> None: | ||
| super().__init__(mix_stderr=False) | ||
| if Version(imp_version('click')) >= Version('8.2.0'): |
There was a problem hiding this comment.
Suggested change
| if Version(imp_version('click')) >= Version('8.2.0'): | |
| if Version(imp_version("click")) >= Version("8.2.0"): |
CI is unhappy because the quotes get reformatted to double quotes, but I think it should be gtg after this.
dsmith111
pushed a commit
to jwstanly/black
that referenced
this pull request
May 15, 2025
MeGaGiGaGon
added a commit
to MeGaGiGaGon/black
that referenced
this pull request
Sep 18, 2025
Not sure on the policy for updating versions, so to cope with the new click 8.3.0 version I used some code from psf#4577 for version conditional behavior. When >= 8.3.0, unset defaults are now the special UNSET sentinal instead of None. Hopefully nothing breaks on the click._utils usage since it's an _ module, might have to find a different solution if it does.
MeGaGiGaGon
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix schema generation error caused by new click version Not sure on the policy for updating versions, so to cope with the new click 8.3.0 version I used some code from #4577 for version conditional behavior. When >= 8.3.0, unset defaults are now the special UNSET sentinal instead of None. Hopefully nothing breaks on the click._utils usage since it's an _ module, might have to find a different solution if it does. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add ignore for mypy error * Actually fix mypy errors with ignore * Add explanation for ignores --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From click 8.2.0 changelog:
so
mix_stderr=Falsethrows an error and is redundant.