Improve generate_schema.py 8.3.0 code #4758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After talking for a bit on the click discord, I was pointed to the `to_info_dict` function. Since the functionality of `to_info_dict` was preserved between 8.2.0 and 8.3.0, using it makes the code much cleaner while having the same effect. Theoretically, the entirety of the function could re-use `to_info_dict`, but there are two problems: No `is_eager` detection, and it's currently untyped besides `dict[str, Any]`, so I decided against it and just did the one improvement.
tusharsadhwani
approved these changes
Sep 19, 2025
JelleZijlstra
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After talking for a bit on the click discord, I was pointed to the
to_info_dictfunction.Since the functionality of
to_info_dictwas preserved between 8.2.0 and 8.3.0, using it makes the code much cleaner while having the same effect.Theoretically, the entirety of the function could re-use
to_info_dict, but there are two problems: Nois_eagerdetection, and it's currently untyped besidesdict[str, Any], so I decided against it and just did the one improvement.Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?