Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handled #4353: Long lines that concatenate list comprehensions#4887

Open
sudhanvapulv wants to merge 3 commits intopsf:mainfrom
sudhanvapulv:feature/concatenated-lc
Open

Handled #4353: Long lines that concatenate list comprehensions#4887
sudhanvapulv wants to merge 3 commits intopsf:mainfrom
sudhanvapulv:feature/concatenated-lc

Conversation

@sudhanvapulv
Copy link

@sudhanvapulv sudhanvapulv commented Dec 6, 2025 •
edited by cobaltt7
Loading

Description

Closes #4353 ticket. Added in implementation in various files to handle this issue including helper functions as well as actual changes.

Checklist - did you ...

  • Implement any code style changes under the --preview style, following the
    stability policy?
  • [Y ] Add an entry in CHANGES.md if necessary? Yes, I did add to changes.md
  • [Y ] Add / update tests if necessary? Yes, I added updated tests.
  • Add new / update outdated documentation?

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

diff-shades results comparing this PR (e4881e9) to main (5b470f0). The full diff is available in the logs under the "Generate HTML diff report" step.

╭─────────────────────── Summary ────────────────────────╮
│ 4 projects & 10 files changed / 134 changes [+76/-58]  │
│                                                        │
│ ... out of 2 846 688 lines, 13 566 files & 22 projects │
╰────────────────────────────────────────────────────────╯

Differences found.

What is this? | Workflow run | diff-shades documentation

cobaltt7
cobaltt7 reviewed Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@cobaltt7 cobaltt7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run Black on the codebase (ie python src/black .)

Some of the diff-shades changes look unideal, could you take a look at them? (click the "available in the logs" link)

Also, as a heads up, now that 25.12.0 has been released, and since we want to keep 26.1.0 limited to purely stabilizing preview styles as much as possible, this probably won't get merged until after 26.1 ships.

tests/data/cases/preview_concatenated_list_comprehensions.py
@@ -0,0 +1,27 @@
# flags: --preview --line-length=120
Copy link
Collaborator

@cobaltt7 cobaltt7 Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for short comprehensions that should stay on one line?

How does this look with a lower line length/splits within the comprehension? Is it still an improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cobaltt7 cobaltt7 cobaltt7 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Long lines that concatenate list comprehensions

2 participants

@sudhanvapulv @cobaltt7