bullet3, oslib, giflib and sail #249
Conversation
f48bd62 to
f12fb6a
Compare
sharkwouter
left a comment
There was a problem hiding this comment.
Hey @jopadan, thanks for the PR! I was just about to write you with info on how to make packages. I had some feedback on how to fix some issues I found with the packages, but this is a great start and not that many changes are needed for them to work well. Keep up the good work!
1961120 to
de88f83
Compare
sharkwouter
left a comment
There was a problem hiding this comment.
I looked at the packages and there are still a couple of things missing from them. I made suggestions for fixes. giflib is mergable at this point and with the suggested changes, bullet3 would be too. Oslib requires a patch to fix the install.
| prepare() { | ||
| cd $pkgname | ||
| git submodule update --init --recursive | ||
| patch -Np1 -i ../psp.patch |
There was a problem hiding this comment.
This will make it so psp-pkgconf will give the correct output. Right now it uses a full path that might not exist on the user's computer.
| patch -Np1 -i ../psp.patch | |
| patch -Np1 -i ../psp.patch | |
| sed -i 's#@PREFIX@#${PSPDEV}/psp#' bullet.pc.cmake |
There was a problem hiding this comment.
sail is still failing to build unfortunately.
Co-authored-by: Wouter Wijsman <[email protected]>
sharkwouter
left a comment
There was a problem hiding this comment.
The sail and bullet3 packages are empty. The oslib and giflib packages look fine now.
|
I made some small adjustments to make this work for us and merged it. Thanks for contributing! |
Uh oh!
There was an error while loading. Please reload this page.